Simplify telemetry namespace helpers#945
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
commit: |
Author
There was a problem hiding this comment.
Implemented the scoped cleanup and babysat the PR.
Summary:
- Trimmed redundant telemetry helper comments around wide-event namespacing.
- Made degraded baseline attributes use
withNamespacelike the computed baseline path. - Added focused
withNamespacecoverage. - Removed unused internal
deslop-jsAST-node helper exports surfaced bydeslop-cli.
Verification:
- Local:
corepack pnpm build - Local:
corepack pnpm test -- tests/build-run-event.test.ts tests/with-namespace.test.tsfrompackages/react-doctor - Local:
corepack pnpm typecheckfrompackages/react-doctor - Local:
corepack pnpm typecheckandcorepack pnpm testfrompackages/deslop-js - PR checks: green across Code Quality, React Doctor, CodeQL, Publish Any Commit, and the full CI matrix.
Notes:
- Posted
/rde parityvia the available PR review channel. No visible/rde parityfollow-up appeared during the watch window. - No Bugbot comments or review findings appeared during the watch window.
- Local
format:checkcould not run becausevp fmt --checkfailed before file checking while loading/workspace/vite.config.tswithERR_UNKNOWN_FILE_EXTENSIONunder Node v22.14.0; the PR Code Qualitylintcheck is green.
Sent by Cursor Automation: React Doctor Cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
withNamespaceunit coveragedeslop-jsAST-node helper exports surfaced bydeslop-cliVerification
corepack pnpm buildcorepack pnpm test -- tests/build-run-event.test.ts tests/with-namespace.test.ts(frompackages/react-doctor)corepack pnpm typecheck(frompackages/react-doctor)corepack pnpm typecheck(frompackages/deslop-js)corepack pnpm test(frompackages/deslop-js)Notes
corepack pnpm format:checkdid not reach file checking:vp fmt --checkfailed loading/workspace/vite.config.tswithERR_UNKNOWN_FILE_EXTENSIONunder Node v22.14.0, despite the package engine allowing this Node range.