Skip to content

Simplify telemetry namespace helpers#945

Draft
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/codebase-architecture-elegance-65ec
Draft

Simplify telemetry namespace helpers#945
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/codebase-architecture-elegance-65ec

Conversation

@cursor

@cursor cursor Bot commented Jun 22, 2026

Copy link
Copy Markdown

Summary

  • Trim redundant telemetry helper comments around wide-event namespacing
  • Make degraded baseline attributes use the shared namespace helper
  • Add focused withNamespace unit coverage
  • Remove unused internal deslop-js AST-node helper exports surfaced by deslop-cli

Verification

  • corepack pnpm build
  • corepack pnpm test -- tests/build-run-event.test.ts tests/with-namespace.test.ts (from packages/react-doctor)
  • corepack pnpm typecheck (from packages/react-doctor)
  • corepack pnpm typecheck (from packages/deslop-js)
  • corepack pnpm test (from packages/deslop-js)

Notes

  • corepack pnpm format:check did not reach file checking: vp fmt --check failed loading /workspace/vite.config.ts with ERR_UNKNOWN_FILE_EXTENSION under Node v22.14.0, despite the package engine allowing this Node range.
Open in Web View Automation 

cursoragent and others added 2 commits June 22, 2026 16:08
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/rde parity

View PR

Open in Web View Automation 

Sent by Cursor Automation: React Doctor Cleanup

@pkg-pr-new

pkg-pr-new Bot commented Jun 22, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-react-doctor@945
npm i https://pkg.pr.new/oxlint-plugin-react-doctor@945
npm i https://pkg.pr.new/react-doctor@945

commit: efb1b1e

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented the scoped cleanup and babysat the PR.

Summary:

  • Trimmed redundant telemetry helper comments around wide-event namespacing.
  • Made degraded baseline attributes use withNamespace like the computed baseline path.
  • Added focused withNamespace coverage.
  • Removed unused internal deslop-js AST-node helper exports surfaced by deslop-cli.

Verification:

  • Local: corepack pnpm build
  • Local: corepack pnpm test -- tests/build-run-event.test.ts tests/with-namespace.test.ts from packages/react-doctor
  • Local: corepack pnpm typecheck from packages/react-doctor
  • Local: corepack pnpm typecheck and corepack pnpm test from packages/deslop-js
  • PR checks: green across Code Quality, React Doctor, CodeQL, Publish Any Commit, and the full CI matrix.

Notes:

  • Posted /rde parity via the available PR review channel. No visible /rde parity follow-up appeared during the watch window.
  • No Bugbot comments or review findings appeared during the watch window.
  • Local format:check could not run because vp fmt --check failed before file checking while loading /workspace/vite.config.ts with ERR_UNKNOWN_FILE_EXTENSION under Node v22.14.0; the PR Code Quality lint check is green.

View PR

Open in Web View Automation 

Sent by Cursor Automation: React Doctor Cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant