Add interactive rule triage#949
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
commit: |
|
interesting |
Merge main and add --pnpm flag to pkg-pr-new publish so it uses pnpm pack (which resolves workspace:* to real versions) instead of npm pack (which does not understand the workspace: protocol). Fixes: npx https://pkg.pr.new/react-doctor@NNN failing with npm error Unsupported URL Type "workspace:": workspace:* Co-Authored-By: nisarg@million.dev <awesomenisarg@gmail.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7862f16. Configure here.
| } | ||
| state = updateTriageState(state, { disabled: [ruleKey] }); | ||
| skippedRuleKeys.add(ruleKey); | ||
| rulesDisabled += 1; |
There was a problem hiding this comment.
Triage marks disabled without config
Medium Severity
When “Disable in doctor.config” cannot write config, triage still records the rule in persisted disabled state, skips it in future sessions, and increments rulesDisabled as if the rule were off, even though lint still runs.
Reviewed by Cursor Bugbot for commit 7862f16. Configure here.
|
|
||
| this.moveCursor(matchingChoiceIndex); | ||
| this.submit(); | ||
| }; |
There was a problem hiding this comment.
Global select patch submits early
Medium Severity
patchSelectKeybindSubmit runs for every prompts() select, so a single letter matching a choice title (e.g. y on “Yes”) moves the cursor and submits immediately, including on CI and action-upgrade prompts that document Esc-only cancel to avoid accidental installs.
Reviewed by Cursor Bugbot for commit 7862f16. Configure here.
2 participants
Summary
react-doctor triage, an interactive rule-by-rule workflow for copying focused fix prompts, skipping rules, or disabling noisy rules in config..react-doctor/triage, write focused diagnostics, add.react-doctor/to gitignore during install, and expose triage from the post-scan handoff menu.Test plan
nr format:checkcd packages/core && nr typecheckcd packages/react-doctor && nr typecheckcd packages/react-doctor && nr test triage-utils.test.tsnr lintNote: full
nr typecheckis blocked locally by unrelated workspace issues (deslop-jsmissingminimatchdeclarations in this install). The touched package checks above pass.Made with Cursor