Skip to content

Refactor scan cleanup regressions#975

Draft
cursor[bot] wants to merge 3 commits into
mainfrom
cursor/codebase-architecture-elegance-0585
Draft

Refactor scan cleanup regressions#975
cursor[bot] wants to merge 3 commits into
mainfrom
cursor/codebase-architecture-elegance-0585

Conversation

@cursor

@cursor cursor Bot commented Jun 26, 2026

Copy link
Copy Markdown

Summary

  • Honor lint: false in the programmatic API by wiring the linter layer gate.
  • Match ignore.overrides rules through existing rule-key aliases.
  • Read staged content relative to monorepo subproject directories.
  • Remove the no-op project-detection renderer and suppress renderer work for JSON scans.
  • Correct run-context command detection for root subcommands.

Verification

  • pnpm build
  • pnpm exec vp test run tests/filter-diagnostics.test.ts tests/services/git.test.ts in packages/core
  • pnpm exec vp test run tests/diagnose.test.ts in packages/api
  • pnpm exec vp test run tests/build-run-context.test.ts in packages/react-doctor
  • pnpm typecheck
  • PATH="/home/ubuntu/.nvm/versions/node/v22.22.2/bin:$PATH" pnpm lint
  • PATH="/home/ubuntu/.nvm/versions/node/v22.22.2/bin:$PATH" pnpm format:check
  • pnpm test
  • pnpm smoke:json-report
Open in Web View Automation 

cursoragent and others added 3 commits June 26, 2026 16:15
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/rde parity

View PR

Open in Web View Automation 

Sent by Cursor Automation: React Doctor Cleanup

@pkg-pr-new

pkg-pr-new Bot commented Jun 26, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-react-doctor@975
npm i https://pkg.pr.new/oxlint-plugin-react-doctor@975
npm i https://pkg.pr.new/react-doctor@975

commit: 157d5a6

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed the cleanup/refactor pass.

What changed:

  • Honored API lint: false by gating the linter layer.
  • Made ignore.overrides rule matching alias-aware via isSameRuleKey.
  • Fixed staged content reads for monorepo subproject cwd paths.
  • Removed the no-op project-detection renderer and skipped terminal rendering work for JSON scans.
  • Fixed run-context command detection for root subcommands.

Verification passed:

  • Focused core/API/CLI tests for touched behavior
  • pnpm build
  • pnpm typecheck
  • pnpm lint with Node 22.22 path
  • pnpm format:check
  • pnpm test
  • pnpm smoke:json-report
  • GitHub PR checks: all green at last poll

Notes:

  • deslop-cli was run; most findings were intentional fixture noise, with overlapping production findings addressed here.
  • truffler could not run because its binary requires bun, which is not available on the VM.
  • I skipped larger/public-surface refactors such as action workflow extraction, website docs/score utility consolidation, and broad rule-helper rewrites.

View PR

Open in Web View Automation 

Sent by Cursor Automation: React Doctor Cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant