Refactor scan cleanup regressions#975
Draft
cursor[bot] wants to merge 3 commits into
Draft
Conversation
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
commit: |
Author
There was a problem hiding this comment.
Completed the cleanup/refactor pass.
What changed:
- Honored API
lint: falseby gating the linter layer. - Made
ignore.overridesrule matching alias-aware viaisSameRuleKey. - Fixed staged content reads for monorepo subproject cwd paths.
- Removed the no-op project-detection renderer and skipped terminal rendering work for JSON scans.
- Fixed run-context command detection for root subcommands.
Verification passed:
- Focused core/API/CLI tests for touched behavior
pnpm buildpnpm typecheckpnpm lintwith Node 22.22 pathpnpm format:checkpnpm testpnpm smoke:json-report- GitHub PR checks: all green at last poll
Notes:
deslop-cliwas run; most findings were intentional fixture noise, with overlapping production findings addressed here.trufflercould not run because its binary requiresbun, which is not available on the VM.- I skipped larger/public-surface refactors such as action workflow extraction, website docs/score utility consolidation, and broad rule-helper rewrites.
Sent by Cursor Automation: React Doctor Cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
lint: falsein the programmatic API by wiring the linter layer gate.ignore.overridesrules through existing rule-key aliases.Verification
pnpm buildpnpm exec vp test run tests/filter-diagnostics.test.ts tests/services/git.test.tsinpackages/corepnpm exec vp test run tests/diagnose.test.tsinpackages/apipnpm exec vp test run tests/build-run-context.test.tsinpackages/react-doctorpnpm typecheckPATH="/home/ubuntu/.nvm/versions/node/v22.22.2/bin:$PATH" pnpm lintPATH="/home/ubuntu/.nvm/versions/node/v22.22.2/bin:$PATH" pnpm format:checkpnpm testpnpm smoke:json-report