-
Notifications
You must be signed in to change notification settings - Fork 419
feat(cli): add experimental interactive Ink TUI #979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 6 commits
6e70c9d
b0c28d6
a5b4c4c
6465f09
181e47a
d46a322
69b001d
b7022f9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "react-doctor": minor | ||
| --- | ||
|
|
||
| Add an experimental interactive TUI (`react-doctor experimental-tui`) built on Ink. It streams diagnostics live during the scan, then renders a scrollable, score-sorted report (no top-3 truncation) with the doctor-face score header, score projection ("you could improve +X%"), per-category breakdown, and an inline syntax-highlighted code frame for the selected issue. It also supports monorepo project selection (an interactive multiselect) and a multi-project summary view with drill-in per project. Ink/React load lazily so the default static, JSON, and score-only paths are unaffected. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -401,6 +401,31 @@ program | |
| .allowUnknownOption() | ||
| .action(() => {}); | ||
|
|
||
| // Gated behind `experimental-` while the interactive Ink report stabilizes | ||
| // (keymap, layout, and the scan-store contract may change). Ink + React load | ||
| // lazily here so the default static path never pays their startup cost. | ||
| program | ||
| .command("experimental-tui [directory]") | ||
| .description("[experimental] interactive, scrollable scan report") | ||
| .option("--no-dead-code", "skip dead-code analysis") | ||
| .option("--no-score", "skip the score API, the share URL, and crash reporting") | ||
| .option("-p, --project <names>", "scan specific workspace projects (comma-separated, or *)") | ||
| .option("-y, --yes", "skip the project prompt and scan every discovered project") | ||
| .action( | ||
| async ( | ||
| directory = ".", | ||
| options: { deadCode?: boolean; score?: boolean; project?: string; yes?: boolean }, | ||
| ) => { | ||
| const { runScanApp } = await import("./ink/run-scan-app.js"); | ||
| await runScanApp({ | ||
| directory, | ||
| options: { deadCode: options.deadCode ?? true, noScore: options.score === false }, | ||
| projectFlag: options.project, | ||
| skipPrompts: options.yes ?? false, | ||
| }); | ||
| }, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TUI always exits zeroMedium Severity
Additional Locations (1)Reviewed by Cursor Bugbot for commit d46a322. Configure here. |
||
| ); | ||
|
|
||
| // HACK: when stdout is piped into a process that closes early (e.g. | ||
| // `react-doctor . | head`), Node throws an uncaught EPIPE on the next | ||
| // write. Exit cleanly instead of dumping a stack trace. | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| import { getCategoryImpact } from "@react-doctor/core"; | ||
| import { Box, Text } from "ink"; | ||
| import { useMemo } from "react"; | ||
| import { buildCodeFrame } from "../../utils/build-code-frame.js"; | ||
| import type { DiagnosticRow } from "../lib/diagnostic-rows.js"; | ||
| import { severityVariant } from "../lib/severity-variants.js"; | ||
|
|
||
| export interface DiagnosticDetailProps { | ||
| readonly row: DiagnosticRow | null; | ||
| readonly rootDirectory: string; | ||
| } | ||
|
|
||
| // Body lines hang-indent via container padding (not a leading string) so a | ||
| // wrapped continuation line lines up under the first line instead of falling | ||
| // back to column 0. | ||
| const DETAIL_INDENT_COLUMNS = 4; | ||
|
|
||
| /** | ||
| * Detail for the selected rule group, styled after the CLI's rule block | ||
| * (`render-diagnostics.ts`): icon + headline, impact prose, the dim `→` fix, | ||
| * the gray location, and the syntax-highlighted source frame at the site. | ||
| */ | ||
| export const DiagnosticDetail = ({ row, rootDirectory }: DiagnosticDetailProps) => { | ||
| const codeFrame = useMemo(() => { | ||
| if (!row) return null; | ||
| const { representative } = row; | ||
| return buildCodeFrame({ | ||
| filePath: representative.filePath, | ||
| line: representative.line, | ||
| column: representative.column, | ||
| rootDirectory, | ||
| }); | ||
| }, [row, rootDirectory]); | ||
|
|
||
| if (!row) return null; | ||
| const variant = severityVariant(row.severity); | ||
| const { representative } = row; | ||
| const impact = getCategoryImpact(row.category); | ||
|
|
||
| return ( | ||
| <Box flexDirection="column"> | ||
| <Text wrap="truncate-end"> | ||
| <Text color={variant.color}> | ||
| {" "} | ||
| {variant.icon}{" "} | ||
| </Text> | ||
| <Text color={variant.color} bold> | ||
| {row.title} | ||
| </Text> | ||
| {row.siteCount > 1 ? <Text dimColor> ×{row.siteCount}</Text> : null} | ||
| </Text> | ||
| <Box flexDirection="column" paddingLeft={DETAIL_INDENT_COLUMNS}> | ||
| <Text dimColor wrap="truncate-end"> | ||
| {row.category} · {variant.label} | ||
| </Text> | ||
| {impact ? ( | ||
| <Text dimColor wrap="wrap"> | ||
| {impact} | ||
| </Text> | ||
| ) : null} | ||
| <Text wrap="wrap">{representative.message}</Text> | ||
| <Text dimColor wrap="truncate-end"> | ||
| {row.location} | ||
| </Text> | ||
| </Box> | ||
| {codeFrame ? ( | ||
| <Box | ||
| marginTop={1} | ||
| marginLeft={DETAIL_INDENT_COLUMNS} | ||
| borderStyle="round" | ||
| borderColor="gray" | ||
| paddingX={1} | ||
| alignSelf="flex-start" | ||
| > | ||
| <Text>{codeFrame}</Text> | ||
| </Box> | ||
| ) : null} | ||
| {representative.help ? ( | ||
| <Box marginTop={1} paddingLeft={DETAIL_INDENT_COLUMNS}> | ||
| <Text dimColor wrap="wrap"> | ||
| → {representative.help} | ||
| </Text> | ||
| </Box> | ||
| ) : null} | ||
| {row.learnMore ? ( | ||
| <Box marginTop={1} paddingLeft={DETAIL_INDENT_COLUMNS}> | ||
| <Text color="cyan" wrap="truncate-end"> | ||
| {row.learnMore} | ||
| </Text> | ||
| </Box> | ||
| ) : null} | ||
| </Box> | ||
| ); | ||
| }; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import { Text } from "ink"; | ||
| import type { DiagnosticRow } from "../lib/diagnostic-rows.js"; | ||
| import { severityVariant } from "../lib/severity-variants.js"; | ||
|
|
||
| export interface DiagnosticItemProps { | ||
| readonly row: DiagnosticRow; | ||
| readonly isSelected: boolean; | ||
| } | ||
|
|
||
| /** | ||
| * One collapsed rule-group line, rendered indented under its category header: | ||
| * `› ✖ Title ×N` — icon + title colored by severity and a dim `×N` site badge, | ||
| * with a `›` pointer on the selected row. The category lives in the header and | ||
| * the file location lives in the detail pane, so the row stays uncluttered. | ||
| */ | ||
| export const DiagnosticItem = ({ row, isSelected }: DiagnosticItemProps) => { | ||
| const variant = severityVariant(row.severity); | ||
|
|
||
| return ( | ||
| <Text wrap="truncate-end"> | ||
| <Text color={isSelected ? variant.color : undefined}>{isSelected ? "› " : " "}</Text> | ||
| <Text color={variant.color}>{variant.icon} </Text> | ||
| <Text color={variant.color} bold={isSelected}> | ||
| {row.title} | ||
| </Text> | ||
| {row.siteCount > 1 ? <Text dimColor> ×{row.siteCount}</Text> : null} | ||
| </Text> | ||
| ); | ||
| }; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,159 @@ | ||
| import { Box, Text, useInput } from "ink"; | ||
| import { useMemo } from "react"; | ||
| import type { ReactNode } from "react"; | ||
| import { useScrollViewport } from "../hooks/use-scroll-viewport.js"; | ||
| import { buildDiagnosticListEntries } from "../lib/diagnostic-list-entries.js"; | ||
| import type { DiagnosticListEntry } from "../lib/diagnostic-list-entries.js"; | ||
| import type { DiagnosticRow } from "../lib/diagnostic-rows.js"; | ||
| import { DiagnosticDetail } from "./diagnostic-detail.js"; | ||
| import { DiagnosticItem } from "./diagnostic-item.js"; | ||
| import { StatusBar } from "./status-bar.js"; | ||
|
|
||
| export type DiagnosticListLayout = "split" | "stacked"; | ||
|
|
||
| export interface DiagnosticListProps { | ||
| /** The score header, rendered above the list (atop the left column in split). */ | ||
| readonly header: ReactNode; | ||
| readonly rows: ReadonlyArray<DiagnosticRow>; | ||
| readonly width: number; | ||
| /** Left-column width in the split layout. */ | ||
| readonly listColumnWidth: number; | ||
| /** Right-column (detail) width in the split layout. */ | ||
| readonly detailColumnWidth: number; | ||
| readonly listHeight: number; | ||
| /** "split" renders the detail beside the list; "stacked" puts it below. */ | ||
| readonly layout: DiagnosticListLayout; | ||
| readonly rootDirectory: string; | ||
| /** When set (monorepo flat view), surfaced in the status bar. */ | ||
| readonly projectCount?: number; | ||
| readonly onExit: () => void; | ||
| readonly exitHint?: string; | ||
| } | ||
|
|
||
| const sumSites = (rows: ReadonlyArray<DiagnosticRow>): number => | ||
| rows.reduce((total, row) => total + row.siteCount, 0); | ||
|
|
||
| const renderEntry = ( | ||
| entry: DiagnosticListEntry, | ||
| entryIndex: number, | ||
| selectedIndex: number, | ||
| ): ReactNode => { | ||
| if (entry.kind === "header") { | ||
| return ( | ||
| <Text key={`header:${entry.category}`} bold wrap="truncate-end"> | ||
| {entry.category} | ||
| </Text> | ||
| ); | ||
| } | ||
| return ( | ||
| <DiagnosticItem | ||
| key={entry.row.ruleKey} | ||
| row={entry.row} | ||
| isSelected={entryIndex === selectedIndex} | ||
| /> | ||
| ); | ||
| }; | ||
|
|
||
| /** | ||
| * The scrollable, category-grouped rule list with a live detail preview — the | ||
| * heart of the interactive report. Each category is a bold header line followed | ||
| * by its rules, so a row reads as "⚠ Title" instead of repeating the category. | ||
| * Scroll/selection (headers skipped) comes from the headless `useScrollViewport`; | ||
| * this component is the chrome on top. On a wide terminal the score header + list | ||
| * sit in the left column and the detail fills the right column; otherwise the | ||
| * detail stacks below. | ||
| */ | ||
| export const DiagnosticList = ({ | ||
| header, | ||
| rows, | ||
| width, | ||
| listColumnWidth, | ||
| detailColumnWidth, | ||
| listHeight, | ||
| layout, | ||
| rootDirectory, | ||
| projectCount, | ||
| onExit, | ||
| exitHint, | ||
| }: DiagnosticListProps) => { | ||
| const entries = useMemo(() => buildDiagnosticListEntries(rows), [rows]); | ||
| const { selectedIndex, visibleStart, visibleEnd } = useScrollViewport({ | ||
| itemCount: entries.length, | ||
| height: listHeight, | ||
| isSelectable: (index) => entries[index]?.kind === "item", | ||
| }); | ||
|
|
||
| useInput((input, key) => { | ||
| if (input === "q" || key.escape) onExit(); | ||
| }); | ||
|
|
||
| const visibleEntries = entries.slice(visibleStart, visibleEnd); | ||
| const selectedEntry = entries[selectedIndex]; | ||
| const selected = selectedEntry?.kind === "item" ? selectedEntry.row : null; | ||
| const errorRows = rows.filter((row) => row.severity === "error"); | ||
| const warningRows = rows.filter((row) => row.severity === "warning"); | ||
| // Position among selectable items only (headers don't count toward the count). | ||
| const itemPosition = entries | ||
| .slice(0, selectedIndex + 1) | ||
| .filter((entry) => entry.kind === "item").length; | ||
|
|
||
| const isSplit = layout === "split"; | ||
|
|
||
| const listColumn = ( | ||
| <Box flexDirection="column" height={listHeight} width={isSplit ? listColumnWidth : width}> | ||
| {visibleEntries.map((entry, index) => | ||
| renderEntry(entry, visibleStart + index, selectedIndex), | ||
| )} | ||
| </Box> | ||
| ); | ||
|
|
||
| const statusBar = ( | ||
| <Box marginTop={1}> | ||
| <StatusBar | ||
| total={sumSites(rows)} | ||
| errorCount={sumSites(errorRows)} | ||
| warningCount={sumSites(warningRows)} | ||
| position={rows.length === 0 ? 0 : itemPosition} | ||
| groupCount={rows.length} | ||
| projectCount={projectCount} | ||
| exitHint={exitHint} | ||
| /> | ||
| </Box> | ||
| ); | ||
|
|
||
| if (isSplit) { | ||
| return ( | ||
| <Box flexDirection="column" width={width}> | ||
| <Box flexDirection="row"> | ||
| <Box flexDirection="column" width={listColumnWidth} marginRight={1}> | ||
| {header} | ||
| <Box marginTop={1}>{listColumn}</Box> | ||
| </Box> | ||
| <Box | ||
| flexDirection="column" | ||
| width={detailColumnWidth} | ||
| borderStyle="single" | ||
| borderColor="gray" | ||
| borderTop={false} | ||
| borderRight={false} | ||
| borderBottom={false} | ||
| paddingLeft={1} | ||
| > | ||
| <DiagnosticDetail row={selected} rootDirectory={rootDirectory} /> | ||
| </Box> | ||
| </Box> | ||
| {statusBar} | ||
| </Box> | ||
| ); | ||
| } | ||
|
|
||
| return ( | ||
| <Box flexDirection="column" width={width}> | ||
| {header} | ||
| <Box marginTop={1}>{listColumn}</Box> | ||
| <Text dimColor>{"─".repeat(width)}</Text> | ||
| <DiagnosticDetail row={selected} rootDirectory={rootDirectory} /> | ||
| {statusBar} | ||
| </Box> | ||
| ); | ||
| }; |


Uh oh!
There was an error while loading. Please reload this page.