Add designing-for-agents skill + no-icon-name-switch rule contract#981
Open
ben-million wants to merge 1 commit into
Open
Add designing-for-agents skill + no-icon-name-switch rule contract#981ben-million wants to merge 1 commit into
ben-million wants to merge 1 commit into
Conversation
Synthesizes the design-to-code skills (paper-flex, paper-to-code-components, reconcile-paper-sync, tailwind-token-consolidation) into generic, tool-agnostic "designing with agents" guidance — the layer above the deterministic rules. - .agents/skills/designing-for-agents: agent failure-mode catalog, the rule-vs-guidance decision, authoring techniques, escape hatches, completion gate - docs/rule-research/no-icon-name-switch.md: stage-1 rule contract for the one new deterministic candidate (a component that switch(name)es to return many inline SVGs) - docs/rule-candidates-backlog.md: backlog entries, incl. a narrower re-open of the previously-dropped no-arbitrary-over-bare-value - .gitignore: allowlist the new skill dir (.agents/skills/* is ignore-by-default) Docs/skills/tooling only — no published-package change, so no changeset. rule-writing + rule-validate (detector + OSS evals) are follow-ups. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
designing-for-agents— a skill that synthesizes our design-to-code skills (paper-flex, paper-to-code-components, reconcile-paper-sync, tailwind-token-consolidation) into generic, tool-agnostic lessons about how coding/design agents fail and how to turn each failure into a countermeasure that holds.React Doctor already encodes the deterministic agent failures as rules. This skill is the layer above: the catalog of failure modes, the rule-vs-guidance decision for each, and the authoring techniques (RED/GREEN intent, pre-enumerated bugs, escape-hatch tables, completion gates) that make a rule diagnostic or skill actually change agent behavior.
Files
.agents/skills/designing-for-agents/SKILL.md— the failure catalog + the rule-vs-guidance decision + authoring techniques + escape hatches + completion gate.docs/rule-research/no-icon-name-switch.md— stage-1rule-researchcontract for the one genuinely new deterministic candidate: a component thatswitches on a prop to return ≥3 distinct inline<svg>bodies (not tree-shakeable; the antipatternpaper-to-code-components§3 exists to stop).docs/rule-candidates-backlog.md— backlog entries for the above, a narrower re-open of the previously-droppedno-arbitrary-over-bare-value(sizing/spacing-on-scale only; default-off, must clear a noise sweep), and a lower-confidenceno-state-for-static-variantnote..gitignore— allowlist the new skill dir (.agents/skills/*is ignore-by-default; each repo-owned skill needs two!un-ignore lines).Key finding
The deterministic design-rule surface is already mature (
design/react-ui/a11y+ the backlog), so most of the synthesis value is judgment-level guidance, not new rules. Only one genuinely new rule candidate fell out — captured here as a contract, not implemented.Not included (follow-ups)
rule-writing+rule-validateforno-icon-name-switch: the detector, adversarial tests, and the OSS eval sweep. It's a medium-FP heuristic, so per our own bar it must not ship without evals. The contract is written so stage 2 can pick it up directly.Notes
🤖 Generated with Claude Code
Note
Low Risk
Docs and agent skills only; no package or linter behavior changes.
Overview
Adds
designing-for-agents— an agent skill that catalogs how coding/design agents fail, when to route fixes to rules vs guidance, and how to author countermeasures (escape hatches, completion gates). It argues most design-agent mistakes are already covered by existing rules and that new value is usually judgment-level guidance, not more linters.Documents the deterministic fallout in
docs/rule-candidates-backlog.md:no-icon-name-switch(prop-driven switch over ≥3 inline SVGs), a narrowerno-on-scale-arbitrary-spacingrevisit of a dropped rule, and a tentativeno-state-for-static-variant. Adds a stage-1docs/rule-research/no-icon-name-switch.mdcontract (detector scope, FP traps, OSS eval gate) without implementing the rule..gitignoreis updated so the new skill directory is tracked like other repo-owned skills.Reviewed by Cursor Bugbot for commit ac2a413. Bugbot is set up for automated code reviews on this repo. Configure here.