Fixes an axis mismatch bug in matrix norm for case -1 and 1 #3827
Open
danlee2002 wants to merge 3 commits into
Open
Fixes an axis mismatch bug in matrix norm for case -1 and 1 #3827danlee2002 wants to merge 3 commits into
danlee2002 wants to merge 3 commits into
Conversation
zcbenz
reviewed
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The following PR aims to fix a matrix norm calculation bug caused by similar reason #3756 for when we are consider the$\pm1$ norm. Since the matrix norm is calculated as a series of reduction. When
keepdimsis false and negatives axes are passed in, the method fails to adjust thecol_axisaccordingly to account for the loss in dimension. This results in either an index out of bound error or the wrong index being reduced along. The following PR normalizes the axes accordingly to account for this reduction.Reproduction
To reproduce the bug
Testing
(3, 3), (2, 3, 3), (2, 3, 3, 3)matricesChecklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes