Skip to content

Changes required to align Playerbots database structure to Azerothcore structure#168

Open
Wishmaster117 wants to merge 1 commit into
mod-playerbots:test-stagingfrom
Wishmaster117:Changes-Needed-to-align-playerbots-database-to-acore-database-structure
Open

Changes required to align Playerbots database structure to Azerothcore structure#168
Wishmaster117 wants to merge 1 commit into
mod-playerbots:test-stagingfrom
Wishmaster117:Changes-Needed-to-align-playerbots-database-to-acore-database-structure

Conversation

@Wishmaster117

@Wishmaster117 Wishmaster117 commented Feb 15, 2026

Copy link
Copy Markdown

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Summary
This PR extends AzerothCore’s built-in database update system to support the PlayerbotsDatabase as a first-class, core-managed database, aligned with how Auth / Characters / World are handled.

Key points:

  • Adds core-level support for the DATABASE_PLAYERBOTS update mask so updates are controlled by the existing core configuration (no module-specific toggle needed).
  • Integrates PlayerbotsDatabase into the same update lifecycle as other DB pools (creation/population/update flow via DBUpdater/UpdateFetcher).
  • Centralizes KeepAlive() handling for PlayerbotsDatabase in the core update loop (same pattern as Login/Character/World).
  • Removes/avoids the need for module-owned database loading toggles so the module does not try to “own” DB lifecycle anymore.

Important

This PR must be merged together with the mod-playerbots PR:
mod-playerbots/mod-playerbots#2141

Issues Addressed:

  • Closes (n/a)

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.
  1. Apply this AzerothCore PR and mod-playerbots PR Battleground system, cross-faction azerothcore/azerothcore-wotlk#2141.
  2. Rebuild the core (worldserver/authserver) and ensure compilation succeeds.
  3. Configure DB connections so the PlayerbotsDatabase is reachable (same as usual for mod-playerbots setups).
  4. Ensure the core DB update system is enabled and includes the DATABASE_PLAYERBOTS mask (via the standard core configuration).
  5. Start worldserver and verify:
  • The Playerbots database update flow runs without ordering errors (tables created before updates that ALTER them).
  • The server no longer requests/depends on any module-specific database update toggle (e.g. Playerbots.Updates.EnableDatabases).
  1. Restart worldserver a second time and verify:
  • No re-application of base/initialization SQL occurs.
  • Only new pending updates (if any) are applied.
  1. Optional regression checks:
  • Normal Auth/Character/World update flow still works unchanged (no regressions in update tables, update ordering, or logs).
  • Player login/logout still updates the correct offline/index statement path when playerbots is enabled.

Known Issues and TODO List:

  • None known at the time of submission.
  • Additional tester coverage welcome (fresh install + existing DB upgrade paths).

@Wishmaster117 Wishmaster117 changed the title Patch Acore 1 Changes required to align Playerbots database structure to Azerothcore structure Feb 15, 2026
hermensbas
hermensbas previously approved these changes Feb 24, 2026
@hermensbas

hermensbas commented Feb 24, 2026

Copy link
Copy Markdown
Collaborator

@Celandriel
Celandriel changed the base branch from Playerbot to test-staging April 12, 2026 18:49
@Celandriel
Celandriel dismissed hermensbas’s stale review April 12, 2026 18:49

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants