feat: Add CMK support in atlas-create-cluster - #1380
Merged
Conversation
manupedrozo
added
the
no-title-validation
manupedrozo
marked this pull request as ready for review
July 23, 2026 07:57
manupedrozo
requested review from
blva and
himanshusinghs
and removed request for
a team and
himanshusinghs
July 23, 2026 07:57
jeroenvervaeke
approved these changes
Jul 24, 2026
laylaazouz
reviewed
Jul 24, 2026
Comment on lines
+445
to
+458
| prompt: `Create a cluster named "${CLUSTER_NAME}" in project "${PROJECT_ID}" on AWS in US_EAST_1 and enable KMS via AWS`, | ||
| mockedTools: { | ||
| ...mockListProjects, | ||
| "atlas-create-cluster": mockCreateClusterResponse({ | ||
| projectId: PROJECT_ID, | ||
| clusterName: CLUSTER_NAME, | ||
| provider: "AWS", | ||
| region: "US_EAST_1", | ||
| }), | ||
| }, | ||
| expectedToolCalls: [ | ||
| ...optionalListProjects, | ||
| { | ||
| toolName: "atlas-create-cluster", |
Collaborator
There was a problem hiding this comment.
Do these test cases cover the 3 cases specified in the TD? (specifically the no preference/unset case)
- An explicitly requested CMK provider is passed to the tool.
- An explicit ask not to use a CMK results in NONE.
- Prompts that do not express a CMK preference leave the input unset.
Collaborator
Author
There was a problem hiding this comment.
Yes, this is covered by existing tests, which do not mention encryption at rest.
If any value is passed for encryptionAtRestProvider in those, the expected call no longer matches and accuracy drops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add encryption at rest via customer-managed key support to the
atlas-create-clustertool.Ticket: CLOUDP-407393
Checklist