Skip to content

Add procMount to nodesets Helm template #2356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
t-chamb wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add procMount to nodesets Helm template #2356

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87007a1
Add procMount to nodesets Helm template
t-chamb Mar 24, 2026
d508f8f
Address review feedback: fix example value, add munge procMount
t-chamb Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions helm/nodesets/templates/nodeset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,9 @@ spec:
security:
limitsConfig: {{ get (.security | default dict) "limitsConfig" | quote }}
appArmorProfile: {{ get (.security | default dict) "appArmorProfile" | default "unconfined" | quote }}
{{- with (get (.security | default dict) "procMount") }}
procMount: {{ . | quote }}
{{- end }}
Comment on lines +137 to +139

Copilot AI Mar 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds spec.slurmd.security.procMount, but the NodeSet CRD also supports spec.munge.security.procMount (same enum). If the intent is full “procMount passthrough” for NodeSets, consider templating it for the munge container as well (and documenting it in values.yaml), otherwise it’s unclear why only slurmd is supported.

Copilot uses AI. Check for mistakes.
{{- end }}

{{- with (required ".Values.nodesets[*].munge is required." .munge) }}
Expand Down
3 changes: 3 additions & 0 deletions helm/nodesets/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,9 @@ nodesets:
# Optional, defaults to empty string
# e.g. `* soft nofile 1024`
limitsConfig: ""
# Proc mount type for the slurmd container
# Optional, valid values: "Default", "Unmasked"
# procMount: ""

Copilot AI Mar 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new values.yaml example suggests procMount: "", but the CRD enum doesn’t allow an empty string (and in this chart it would also be treated as “unset” and omitted). Consider changing the commented example to a valid value (e.g. "Default" or "Unmasked") so users don’t copy an ineffective/invalid setting.

Suggested change
# procMount: ""
# procMount: "Default"

Copilot uses AI. Check for mistakes.
# Munge configuration
munge:
# Each particular NodeSet's containers can have images other than default ones
Expand Down
Loading