Skip to content

feat(gui): improve CLI help output and argument validation#10069

Open
joshtrichards wants to merge 8 commits into
masterfrom
jtr/fix-cli-parser-overridelocaldir
Open

feat(gui): improve CLI help output and argument validation#10069
joshtrichards wants to merge 8 commits into
masterfrom
jtr/fix-cli-parser-overridelocaldir

chore(app): fixup typo

7ceba7e
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 20, 2026 in 22m 12s

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
D Security Rating on New Code (required ≥ A)
22 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 707 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "cfg" of type "class OCC::ConfigFile" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5GNEaM2NDva-OwA1kd&open=AZ5GNEaM2NDva-OwA1kd&pullRequest=10069

Check failure on line 688 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this TOCTOU race condition window when accessing files 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5GNEaM2NDva-OwA1kb&open=AZ5GNEaM2NDva-OwA1kb&pullRequest=10069

Check warning on line 990 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "isUrlValid" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5GNEaM2NDva-OwA1kg&open=AZ5GNEaM2NDva-OwA1kg&pullRequest=10069

Check warning on line 1140 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "configLanguage" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5GNEaM2NDva-OwA1kl&open=AZ5GNEaM2NDva-OwA1kl&pullRequest=10069

Check warning on line 705 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function should be declared "const". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5GNEaM2NDva-OwA1kc&open=AZ5GNEaM2NDva-OwA1kc&pullRequest=10069

Check failure on line 636 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5GNEaM2NDva-OwA1kY&open=AZ5GNEaM2NDva-OwA1kY&pullRequest=10069

Check warning on line 1201 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this "if" statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5GNEaM2NDva-OwA1kn&open=AZ5GNEaM2NDva-OwA1kn&pullRequest=10069

Check failure on line 692 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5GNEaM2NDva-OwA1ka&open=AZ5GNEaM2NDva-OwA1ka&pullRequest=10069

Check failure on line 340 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this TOCTOU race condition window when accessing files 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5GNEaM2NDva-OwA1kU&open=AZ5GNEaM2NDva-OwA1kU&pullRequest=10069

Check warning on line 1193 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this "if" statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5GNEaM2NDva-OwA1ko&open=AZ5GNEaM2NDva-OwA1ko&pullRequest=10069

Check warning on line 348 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "->" with "::" for access to "Theme::doNotUseProxy". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5GNEaM2NDva-OwA1kW&open=AZ5GNEaM2NDva-OwA1kW&pullRequest=10069

Check warning on line 446 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "->" with "::" for access to "Theme::doNotUseProxy". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5GNEaM2NDva-OwA1kX&open=AZ5GNEaM2NDva-OwA1kX&pullRequest=10069

Check failure on line 328 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this TOCTOU race condition window when accessing files 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5GNEaM2NDva-OwA1kV&open=AZ5GNEaM2NDva-OwA1kV&pullRequest=10069

Check failure on line 967 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5GNEaM2NDva-OwA1kh&open=AZ5GNEaM2NDva-OwA1kh&pullRequest=10069

Check warning on line 916 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "shortName" of type "const char *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5GNEaM2NDva-OwA1kj&open=AZ5GNEaM2NDva-OwA1kj&pullRequest=10069

Check warning on line 999 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Take the required action to fix the issue indicated by this "FIXME" comment. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5GNEaM2NDva-OwA1kS&open=AZ5GNEaM2NDva-OwA1kS&pullRequest=10069

Check warning on line 784 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5GNEaM2NDva-OwA1ke&open=AZ5GNEaM2NDva-OwA1ke&pullRequest=10069

Check warning on line 653 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function should be declared "const". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5GNEaM2NDva-OwA1kZ&open=AZ5GNEaM2NDva-OwA1kZ&pullRequest=10069

Check warning on line 784 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function should be declared "const". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5GNEaM2NDva-OwA1kf&open=AZ5GNEaM2NDva-OwA1kf&pullRequest=10069

Check warning on line 152 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "shouldTryToMigrate" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5GNEaM2NDva-OwA1kT&open=AZ5GNEaM2NDva-OwA1kT&pullRequest=10069

Check warning on line 944 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Take the required action to fix the issue indicated by this "FIXME" comment. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5GNEaM2NDva-OwA1kR&open=AZ5GNEaM2NDva-OwA1kR&pullRequest=10069

Check warning on line 916 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "name" of type "const char *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5GNEaM2NDva-OwA1ki&open=AZ5GNEaM2NDva-OwA1ki&pullRequest=10069

Check failure on line 1192 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5GNEaM2NDva-OwA1km&open=AZ5GNEaM2NDva-OwA1km&pullRequest=10069

Check warning on line 985 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Avoid this unnecessary copy by using a "const" reference. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5GNEaM2NDva-OwA1kk&open=AZ5GNEaM2NDva-OwA1kk&pullRequest=10069

Check warning on line 1251 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the redundant type with "auto". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5GNEaM2NDva-OwA1kp&open=AZ5GNEaM2NDva-OwA1kp&pullRequest=10069
View more details on SonarQubeCloud