Skip to content

fix(ldap): extract config set to standalone script#485

Open
Antreesy wants to merge 1 commit into
fix/noid/ignore-data-extrafrom
fix/noid/reuse-configure-ldap
Open

fix(ldap): extract config set to standalone script#485
Antreesy wants to merge 1 commit into
fix/noid/ignore-data-extrafrom
fix/noid/reuse-configure-ldap

Conversation

@Antreesy

@Antreesy Antreesy commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Extract ldap configuration from bootstrap.sh to standalone script

  • allows to set ldap during bootstrap, but also later when instance is up and running
  • add new script to Dockerfile
  • Needs image rebuild?

To test:

docker compose up -d nextcloud proxy
# optional to not rebuild
docker compose cp docker/bin/configure-ldap.sh nextcloud:/usr/local/bin/configure-ldap.sh
docker compose exec nextcloud chmod +x /usr/local/bin/configure-ldap.sh
# 
docker compose up -d ldap ldapadmin

# either
docker compose exec nextcloud configure-ldap.sh
# or
./scripts/enable-ldap.sh nextcloud

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

- allow to set up ldap in both ways:
  - during bootstrap.sh
  - after instance setup, by calling enable-ldap.sh

Assisted-by: ClaudeCode:claude-opus-4-8
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy self-assigned this Jul 9, 2026
@Antreesy Antreesy requested a review from blizzz July 9, 2026 10:32

@blizzz blizzz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants