Skip to content

Compatibility for Nodejs 6.x - #4

Open
hlapp wants to merge 2 commits into
ninjablocks:masterfrom
hlapp:fix-for-nodejs6
Open

Compatibility for Nodejs 6.x#4
hlapp wants to merge 2 commits into
ninjablocks:masterfrom
hlapp:fix-for-nodejs6

Conversation

@hlapp

@hlapp hlapp commented Feb 5, 2018

Copy link
Copy Markdown
Collaborator

Running under Nodejs 6.x requires upgrading serialport to 6.x.x, which includes API and behavior changes compared to the 2.x.x version usable under Nodejs 0.12.x and up to Nodejs 4.x.

The dependency on the ninjablocks/node-serialport fork fails to install on nodejs 4.x,
and likely would on 0.12.x as well.

Also increments version, and adds minimum nodejs version according to serialport
declaration. This is to distinguish from previous version.
Also includes the code changes necessary to continue working under
Nodejs 6.x.
@elliots

elliots commented Feb 5, 2018

Copy link
Copy Markdown
Member

Wow, thanks @hlapp ... I assume this is a breaking change for people using ancient node?
Do you know if the rest of the ninja node app work ok in Node 0.12+?

@hlapp

hlapp commented Feb 5, 2018

Copy link
Copy Markdown
Collaborator Author

I assume this is a breaking change for people using ancient node?

Yes, the breaking change comes from serialport, and for this change ancient include Nodejs 4.x. (Nodejs 4.x will work with serialport 4.x, but not higher, according to serialport documentation.)

Do you know if the rest of the ninja node app work ok in Node 0.12+?

Yes, I have it running now under Nodejs 6.x. Also requires hlapp/ninjablocks-utilities@3c6493b.

For 0.12.x <= Nodejs <= 4.x, you will need #3 here, and the pull requests I have made for ninjablocks/utilities. Also changes here hlapp/ninjablocks-client@master-local. I use https://github.com/hlapp/ninja-mqtt to communicate via MQTT.

@elliots

elliots commented Feb 5, 2018

Copy link
Copy Markdown
Member

@hlapp , i've sent you write access invitation to this repo and utilities. If you accept, feel free to accept your own pull requests :)

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants