harmonia-store-ref-scan: add README.md#1091
Merged
Merged
Conversation
Cargo.toml declares readme = "README.md" but the file did not exist, which makes `cargo package` (and tooling that calls it, e.g. crane's git-dep vendoring) fail with "readme README.md does not appear to exist". Every other workspace member already ships its own README.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA new Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Mic92
added a commit
to Mic92/tribuchet
that referenced
this pull request
Jun 23, 2026
rustPlatform.buildRustPackage rebuilds every crate in Cargo.lock on
any source change. Splitting the build into crane's buildDepsOnly +
buildPackage keeps the ~300 dependency crates (incl. the harmonia git
deps and tonic-build) in their own derivation that only rebuilds when
Cargo.{toml,lock} change, taking incremental builds from ~3m to ~30s.
Bumps the harmonia rev past nix-community/harmonia#1091 so crane's
git-dep vendoring (which runs cargo package -l) no longer trips on
harmonia-store-ref-scan's missing README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cargo.toml declares readme = "README.md" but the file did not exist,
which makes
cargo package(and tooling that calls it, e.g. crane'sgit-dep vendoring) fail with "readme README.md does not appear to
exist". Every other workspace member already ships its own README.