Skip to content

misc: remove open from proto - #808

Merged
sharvilshah merged 1 commit into
mainfrom
sbs/remove-unused-open-message-from-proto
Feb 23, 2026
Merged

misc: remove open from proto#808
sharvilshah merged 1 commit into
mainfrom
sbs/remove-unused-open-message-from-proto

Conversation

@sharvilshah

Copy link
Copy Markdown
Contributor

Remove dead code

@sharvilshah
sharvilshah requested a review from a team as a code owner February 23, 2026 20:45
@coderabbitai

coderabbitai Bot commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7c9c0a2 and bf267d8.

📒 Files selected for processing (1)
  • Source/common/santa.proto
💤 Files with no reviewable changes (1)
  • Source/common/santa.proto

📝 Walkthrough

Walkthrough

The Open message definition has been removed from the Santa protocol buffer definition. This eliminates the event type along with its associated fields for instigator, target, and flags, reducing the available event types in the SantaMessage oneof.

Changes

Cohort / File(s) Summary
Proto Definition
Source/common/santa.proto
Removed the Open message definition containing instigator, target, and flags fields from the SantaMessage event set.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title mentions removing 'open' from proto, which directly matches the main change of removing the Open message from the Santa protocol definition.
Description check ✅ Passed The description 'Remove dead code' is related to the changeset, as the removed Open message appears to be unused code based on the PR context.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sbs/remove-unused-open-message-from-proto

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@sharvilshah
sharvilshah merged commit e8c53e2 into main Feb 23, 2026
7 checks passed
@sharvilshah
sharvilshah deleted the sbs/remove-unused-open-message-from-proto branch February 23, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants