Skip to content

Cleanup of the 93m1 applications - #29

Merged
SyverHaraldsen merged 2 commits into
mainfrom
applications-93-cleanup
Jun 25, 2026
Merged

Cleanup of the 93m1 applications#29
SyverHaraldsen merged 2 commits into
mainfrom
applications-93-cleanup

applications: 93m1_at: General cleanup of the 93m1_at application

ab5c6f8
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jun 25, 2026 in 26s

Annotations

Check warning on line 97 in applications/93m1_at/src/modules/network/network.c

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this parameter a pointer-to-const. The current type of "cb" is "struct net_mgmt_event_callback *".

See more on https://sonarcloud.io/project/issues?id=ncs-serial-modem-host-applications&issues=AZ75kJjlzn9ckNrrWwVy&open=AZ75kJjlzn9ckNrrWwVy&pullRequest=29

Check warning on line 98 in applications/93m1_at/src/modules/network/network.c

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this parameter a pointer-to-const. The current type of "iface" is "struct net_if *".

See more on https://sonarcloud.io/project/issues?id=ncs-serial-modem-host-applications&issues=AZ75kJjlzn9ckNrrWwVz&open=AZ75kJjlzn9ckNrrWwVz&pullRequest=29

Check warning on line 76 in applications/93m1_at/src/modules/network/network.c

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this parameter a pointer-to-const. The current type of "cb" is "struct net_mgmt_event_callback *".

See more on https://sonarcloud.io/project/issues?id=ncs-serial-modem-host-applications&issues=AZ75kJjlzn9ckNrrWwVx&open=AZ75kJjlzn9ckNrrWwVx&pullRequest=29

Check warning on line 78 in applications/93m1_at/src/modules/cloud/cloud.c

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this "switch" statement by "if" statements to increase readability.

See more on https://sonarcloud.io/project/issues?id=ncs-serial-modem-host-applications&issues=AZ75kJf3zn9ckNrrWwVw&open=AZ75kJf3zn9ckNrrWwVw&pullRequest=29