bluetooth: hids: Fix bt_hogp_rep_unsubscribe issue - #28385
Merged
Conversation
Contributor
CI InformationTo view the history of this post, click the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 77f3068ea2332fe6a3f54793a6395a0d898362a8 more detailssdk-nrf:
Github labels
List of changed files detected by CI (3)Outputs:ToolchainVersion: eb11c27a58 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
maje-emb
reviewed
Apr 28, 2026
ahasztag
commented
Apr 29, 2026
ahasztag
force-pushed
the
fix/hogp_rep_unsubscribe
branch
from
April 29, 2026 09:50
5762fd7 to
eba3fd1
Compare
MarekPieta
requested changes
Apr 29, 2026
ahasztag
force-pushed
the
fix/hogp_rep_unsubscribe
branch
6 times, most recently
from
May 4, 2026 05:21
618337d to
54df903
Compare
ahasztag
commented
May 4, 2026
ahasztag
force-pushed
the
fix/hogp_rep_unsubscribe
branch
from
May 4, 2026 06:40
54df903 to
59580d1
Compare
ahasztag
marked this pull request as draft
May 4, 2026 08:39
ahasztag
marked this pull request as ready for review
May 4, 2026 08:49
ahasztag
commented
May 4, 2026
MarekPieta
reviewed
May 5, 2026
ahasztag
force-pushed
the
fix/hogp_rep_unsubscribe
branch
from
May 6, 2026 06:12
59580d1 to
4b92af2
Compare
peknis
requested changes
May 6, 2026
|
You can find the documentation preview for this PR here. Preview links for modified nRF Connect SDK documents: |
ahasztag
force-pushed
the
fix/hogp_rep_unsubscribe
branch
from
May 6, 2026 06:58
53d67b7 to
0e7d995
Compare
peknis
approved these changes
May 6, 2026
ahasztag
force-pushed
the
fix/hogp_rep_unsubscribe
branch
from
May 8, 2026 07:11
0e7d995 to
6dee16c
Compare
ahasztag
force-pushed
the
fix/hogp_rep_unsubscribe
branch
from
May 8, 2026 08:39
6dee16c to
e80c56a
Compare
ahasztag
force-pushed
the
fix/hogp_rep_unsubscribe
branch
2 times, most recently
from
May 8, 2026 11:31
86eed26 to
e98eca9
Compare
maje-emb
reviewed
May 8, 2026
ahasztag
force-pushed
the
fix/hogp_rep_unsubscribe
branch
from
May 11, 2026 06:24
e98eca9 to
6d81c97
Compare
MarekPieta
approved these changes
May 11, 2026
ahasztag
force-pushed
the
fix/hogp_rep_unsubscribe
branch
from
May 11, 2026 07:58
6d81c97 to
16fc061
Compare
The bt_hogp_rep_unsubscribe did not reset the rep->notify_cb, while bt_hogp_rep_subscribe returned an error if notify_cb was not null. Thus, it would be impossible to subscribe again to the report notification after unsubscribing. This commit fixes this. Signed-off-by: Artur Hadasz <artur.hadasz@nordicsemi.no>
ahasztag
force-pushed
the
fix/hogp_rep_unsubscribe
branch
from
May 11, 2026 08:04
16fc061 to
77f3068
Compare
MarekPieta
approved these changes
May 11, 2026
maje-emb
approved these changes
May 11, 2026
alexstanoev-nordic
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bt_hogp_rep_unsubscribe did not reset the rep->notify_cb, while bt_hogp_rep_subscribe returned an error if
notify_cb was not null. Thus, it would be impossible to subscribe again to the report notification after unsubscribing.
This commit fixes this.