Skip to content

bluetooth: hids: Fix bt_hogp_rep_unsubscribe issue - #28385

Merged
nordicjm merged 1 commit into
nrfconnect:mainfrom
ahasztag:fix/hogp_rep_unsubscribe
May 13, 2026
Merged

bluetooth: hids: Fix bt_hogp_rep_unsubscribe issue#28385
nordicjm merged 1 commit into
nrfconnect:mainfrom
ahasztag:fix/hogp_rep_unsubscribe

Conversation

@ahasztag

Copy link
Copy Markdown
Contributor

The bt_hogp_rep_unsubscribe did not reset the rep->notify_cb, while bt_hogp_rep_subscribe returned an error if
notify_cb was not null. Thus, it would be impossible to subscribe again to the report notification after unsubscribing.

This commit fixes this.

@ahasztag
ahasztag requested a review from a team April 24, 2026 12:07
@ahasztag
ahasztag requested a review from a team as a code owner April 24, 2026 12:07
@NordicBuilder

NordicBuilder commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

CI Information

To view the history of this post, click the 'edited' button above
Build number: 20

Inputs:

Sources:

sdk-nrf: PR head: 77f3068ea2332fe6a3f54793a6395a0d898362a8

more details

sdk-nrf:

PR head: 77f3068ea2332fe6a3f54793a6395a0d898362a8
merge base: 23c9617a817c11e291e8903f2a5023cd63fa2942
target head (main): 15069748d85c0283235dd80c573f1d2fae694fcf
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (3)
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
include
│  ├── bluetooth
│  │  ├── services
│  │  │  │ hogp.h
subsys
│  ├── bluetooth
│  │  ├── services
│  │  │  │ hogp.c

Outputs:

Toolchain

Version: eb11c27a58
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:eb11c27a58_5ea73affbf

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 19
  • ✅ Integration tests
    • ✅ desktop52_verification - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test_ble_nrf_config - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-ble_samples
    • ✅ test-sdk-find-my - Skipped: Job was skipped as it succeeded in a previous run
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_mosh
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-mcuboot
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

Comment thread subsys/bluetooth/services/hogp.c Outdated
Comment thread subsys/bluetooth/services/hogp.c Outdated
@ahasztag
ahasztag force-pushed the fix/hogp_rep_unsubscribe branch from 5762fd7 to eba3fd1 Compare April 29, 2026 09:50
Comment thread subsys/bluetooth/services/hogp.c Outdated
Comment thread subsys/bluetooth/services/hogp.c Outdated
Comment thread subsys/bluetooth/services/hogp.c Outdated
@ahasztag
ahasztag force-pushed the fix/hogp_rep_unsubscribe branch 6 times, most recently from 618337d to 54df903 Compare May 4, 2026 05:21
Comment thread subsys/bluetooth/services/hogp.c
@ahasztag
ahasztag requested review from MarekPieta and maje-emb May 4, 2026 05:23
@ahasztag
ahasztag force-pushed the fix/hogp_rep_unsubscribe branch from 54df903 to 59580d1 Compare May 4, 2026 06:40
@ahasztag
ahasztag marked this pull request as draft May 4, 2026 08:39
@ahasztag
ahasztag marked this pull request as ready for review May 4, 2026 08:49
Comment thread subsys/bluetooth/services/hogp.c
Comment thread subsys/bluetooth/services/hogp.c
@ahasztag
ahasztag force-pushed the fix/hogp_rep_unsubscribe branch from 59580d1 to 4b92af2 Compare May 6, 2026 06:12
@ahasztag
ahasztag requested a review from a team as a code owner May 6, 2026 06:12
@NordicBuilder NordicBuilder added doc-required PR must not be merged without tech writer approval. changelog labels May 6, 2026
Comment thread doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst Outdated
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown

You can find the documentation preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsbmdoc.z6.web.core.windows.net/ncs/PR-28385/nrf/releases_and_maturity/releases/release-notes-changelog.html

@ahasztag
ahasztag requested a review from MarekPieta May 6, 2026 06:57
@ahasztag
ahasztag force-pushed the fix/hogp_rep_unsubscribe branch from 53d67b7 to 0e7d995 Compare May 6, 2026 06:58
@ahasztag
ahasztag requested a review from peknis May 6, 2026 06:58
@ahasztag
ahasztag force-pushed the fix/hogp_rep_unsubscribe branch from 0e7d995 to 6dee16c Compare May 8, 2026 07:11
@NordicBuilder NordicBuilder removed doc-required PR must not be merged without tech writer approval. changelog labels May 8, 2026
@ahasztag
ahasztag force-pushed the fix/hogp_rep_unsubscribe branch from 6dee16c to e80c56a Compare May 8, 2026 08:39
@NordicBuilder NordicBuilder added the doc-required PR must not be merged without tech writer approval. label May 8, 2026
@ahasztag
ahasztag force-pushed the fix/hogp_rep_unsubscribe branch 2 times, most recently from 86eed26 to e98eca9 Compare May 8, 2026 11:31
Comment thread subsys/bluetooth/services/hogp.c
Comment thread subsys/bluetooth/services/hogp.c Outdated
Comment thread subsys/bluetooth/services/hogp.c Outdated
@ahasztag
ahasztag force-pushed the fix/hogp_rep_unsubscribe branch from e98eca9 to 6d81c97 Compare May 11, 2026 06:24
Comment thread subsys/bluetooth/services/hogp.c Outdated
Comment thread doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst Outdated
Comment thread include/bluetooth/services/hogp.h Outdated
@ahasztag
ahasztag force-pushed the fix/hogp_rep_unsubscribe branch from 6d81c97 to 16fc061 Compare May 11, 2026 07:58
The bt_hogp_rep_unsubscribe did not reset the rep->notify_cb,
while bt_hogp_rep_subscribe returned an error if
notify_cb was not null. Thus, it would be impossible
to subscribe again to the report notification after
unsubscribing.

This commit fixes this.

Signed-off-by: Artur Hadasz <artur.hadasz@nordicsemi.no>
@ahasztag
ahasztag force-pushed the fix/hogp_rep_unsubscribe branch from 16fc061 to 77f3068 Compare May 11, 2026 08:04
@ahasztag ahasztag added bug bugfix Fixes a known bug labels May 13, 2026
@ahasztag ahasztag added this to the 3.4.0 milestone May 13, 2026
@nordicjm
nordicjm merged commit b21d678 into nrfconnect:main May 13, 2026
24 of 25 checks passed
@ahasztag
ahasztag deleted the fix/hogp_rep_unsubscribe branch June 23, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixes a known bug changelog doc-required PR must not be merged without tech writer approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants