Skip to content

samples: crypto: migrate nRF5340 NS builds off Partition Manager - #28543

Merged
rlubos merged 1 commit into
nrfconnect:mainfrom
degjorva:pm-removal-crypto-samples-5340
May 18, 2026
Merged

samples: crypto: migrate nRF5340 NS builds off Partition Manager#28543
rlubos merged 1 commit into
nrfconnect:mainfrom
degjorva:pm-removal-crypto-samples-5340

Conversation

@degjorva

@degjorva degjorva commented May 5, 2026

Copy link
Copy Markdown
Contributor

Disable Partition Manager for the nRF5340/ns target.

For psa_tls also:
Extend the DTS layout to nrf54lv10a/cpuapp/ns (new overlay) and update the nrf54l10/cpuapp/ns overlay. The stock DTS split allocates only 96 kB (nrf54l10) / 92 kB (nrf54lv10a) of SRAM to the non-secure. This new overlay matches the previous Partition Manager layout

Fix nrf54lv10dk_nrf54lv10_cpuapp_ns.conf filename that was missing the 'a' variant suffix and was not being picked up by the build.

@degjorva
degjorva requested review from a team as code owners May 5, 2026 14:02
label = "tfm-ps";
reg = <0x8000 DT_SIZE_K(16)>;
};

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed for all. Direct output from migration script so seems to be a small error there.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

label = "tfm-ps";
reg = <0x8000 DT_SIZE_K(16)>;
};

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

fix in all files

@degjorva
degjorva force-pushed the pm-removal-crypto-samples-5340 branch from 62709d1 to f0aba7e Compare May 5, 2026 14:12
Comment thread samples/crypto/aes_cbc/boards/nrf5340dk_nrf5340_cpuapp_ns.overlay
@NordicBuilder

NordicBuilder commented May 5, 2026

Copy link
Copy Markdown
Contributor

CI Information

To view the history of this post, click the 'edited' button above
Build number: 5

Inputs:

Sources:

sdk-nrf: PR head: 5b770c4eff97005cc932df3c8d88fbaf9d33c9ab

more details

sdk-nrf:

PR head: 5b770c4eff97005cc932df3c8d88fbaf9d33c9ab
merge base: f6591980906f19ad64c960cb4840333dd3b8c2c9
target head (main): 12cf3039c43368bc1a6aa54f867ab30ebb16a377
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (41)
samples
│  ├── crypto
│  │  ├── aes_cbc
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── boards
│  │  │  │  │ nrf5340dk_nrf5340_cpuapp_ns.overlay
│  │  ├── aes_ccm
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── boards
│  │  │  │  │ nrf5340dk_nrf5340_cpuapp_ns.overlay
│  │  ├── aes_ctr
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── boards
│  │  │  │  │ nrf5340dk_nrf5340_cpuapp_ns.overlay
│  │  ├── aes_gcm
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── boards
│  │  │  │  │ nrf5340dk_nrf5340_cpuapp_ns.overlay
│  │  ├── chachapoly
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── boards
│  │  │  │  │ nrf5340dk_nrf5340_cpuapp_ns.overlay
│  │  ├── ecdh
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── boards
│  │  │  │  │ nrf5340dk_nrf5340_cpuapp_ns.overlay
│  │  ├── ecdsa
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── boards
│  │  │  │  │ nrf5340dk_nrf5340_cpuapp_ns.overlay
│  │  ├── ecjpake
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── boards
│  │  │  │  │ nrf5340dk_nrf5340_cpuapp_ns.overlay
│  │  ├── eddsa
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── boards
│  │  │  │  │ nrf5340dk_nrf5340_cpuapp_ns.overlay
│  │  ├── hkdf
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── boards
│  │  │  │  │ nrf5340dk_nrf5340_cpuapp_ns.overlay
│  │  ├── hmac
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── boards
│  │  │  │  │ nrf5340dk_nrf5340_cpuapp_ns.overlay
│  │  ├── pbkdf2
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── boards
│  │  │  │  │ nrf5340dk_nrf5340_cpuapp_ns.overlay
│  │  ├── persistent_key_usage
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── boards
│  │  │  │  │ nrf5340dk_nrf5340_cpuapp_ns.overlay
│  │  ├── psa_tls
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── boards
│  │  │  │  ├── nrf5340dk_nrf5340_cpuapp_ns.overlay
│  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp_ns.overlay
│  │  │  │  ├── nrf54lv10dk_nrf54lv10a_cpuapp_ns.conf
│  │  │  │  │ nrf54lv10dk_nrf54lv10a_cpuapp_ns.overlay
│  │  ├── rng
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── boards
│  │  │  │  │ nrf5340dk_nrf5340_cpuapp_ns.overlay
│  │  ├── rsa
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── boards
│  │  │  │  │ nrf5340dk_nrf5340_cpuapp_ns.overlay
│  │  ├── sha256
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── boards
│  │  │  │  ├── nrf5340dk_nrf5340_cpuapp_ns.overlay
│  │  │  │  │ nrf5340dk_nrf5340_cpuapp_ns_mcuboot.overlay
│  │  │  │ sample.yaml
│  │  ├── spake2p
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── boards
│  │  │  │  │ nrf5340dk_nrf5340_cpuapp_ns.overlay

Outputs:

Toolchain

Version: f0aa129f09
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:f0aa129f09_5ea73affbf

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 684
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-nrf_crypto
    • ✅ test-secdom-samples-public
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_mosh
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • desktop52_verification
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-wifi

Note: This message is automatically posted and updated by the CI

Comment thread samples/crypto/aes_cbc/boards/nrf5340dk_nrf5340_cpuapp_ns.overlay
@degjorva
degjorva force-pushed the pm-removal-crypto-samples-5340 branch from f0aba7e to e0f6e8c Compare May 6, 2026 13:35
@degjorva
degjorva requested a review from nordicjm May 6, 2026 13:37
@degjorva degjorva added this to the 3.4.0 milestone May 12, 2026
@degjorva
degjorva force-pushed the pm-removal-crypto-samples-5340 branch from e0f6e8c to 3766296 Compare May 13, 2026 08:39
@github-actions

Copy link
Copy Markdown

You can find the documentation preview for this PR here.

@degjorva
degjorva force-pushed the pm-removal-crypto-samples-5340 branch from 3766296 to 1d38898 Compare May 13, 2026 13:54
Disable Partition Manager for the nRF5340/ns target.

For psa_tls also:
Extend the DTS layout to nrf54lv10a/cpuapp/ns (new overlay) and
update the nrf54l10/cpuapp/ns overlay. The stock DTS split allocates
only 96 kB (nrf54l10) / 92 kB (nrf54lv10a) of SRAM to the non-secure.
This new overlay matches the previous Partition Manager layout

Fix nrf54lv10dk_nrf54lv10_cpuapp_ns.conf filename that was missing
the 'a' variant suffix and was not being picked up by the build.

Signed-off-by: Dag Erik Gjørvad <dag.erik.gjorvad@nordicsemi.no>
@degjorva
degjorva force-pushed the pm-removal-crypto-samples-5340 branch from 1d38898 to 5b770c4 Compare May 15, 2026 11:58

@frkv frkv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rlubos
rlubos merged commit c15cb21 into nrfconnect:main May 18, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants