Skip to content

tools: Remove matter-idl from package - #30555

Merged
jangalda-nsc merged 1 commit into
nrfconnect:mainfrom
jangalda-nsc:no-matter-idl
Aug 7, 2026
Merged

tools: Remove matter-idl from package#30555
jangalda-nsc merged 1 commit into
nrfconnect:mainfrom
jangalda-nsc:no-matter-idl

Conversation

@jangalda-nsc

Copy link
Copy Markdown
Contributor

Matter samples moved to add-on

Matter samples moved to add-on

Signed-off-by: Jan Gałda <jan.galda@nordicsemi.no>
@jangalda-nsc
jangalda-nsc requested review from a team as code owners August 6, 2026 07:48
Copilot AI lite review requested due to automatic review settings August 6, 2026 07:48

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Ready to approve

The changes are small, internally consistent across the requirements files, and a repo-wide search shows no remaining references to matter-idl / matter_idl.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

This PR updates the Python dependency sets under scripts/ to remove the matter-idl dependency now that Matter samples have been moved to an add-on, while also refreshing a GitPython pin and keeping pip-audit noise manageable via the existing whitelist mechanism.

Changes:

  • Remove matter-idl / matter_idl from the extra and fixed requirement sets.
  • Bump GitPython from 3.1.57 to 3.1.58 in both the fixed lock and CI requirements.
  • Add additional py advisories to scripts/pip-audit-whitelist.yml.
File summaries
File Description
scripts/requirements-fixed.txt Drops matter-idl from the generated lockfile and updates the pinned gitpython version.
scripts/requirements-extra.txt Removes matter_idl from the extra requirements list.
scripts/requirements-ci.txt Updates the minimum GitPython version used in CI.
scripts/pip-audit-whitelist.yml Extends the existing py vulnerability allowlist with three additional advisory IDs.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

@NordicBuilder

NordicBuilder commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

CI Information

To view the history of this post, click the 'edited' button above
Build number: 4

Inputs:

Sources:

sdk-nrf: PR head: 36602770fb9009afe79df97e0fb45ea0bb944b2f

more details

sdk-nrf:

PR head: 36602770fb9009afe79df97e0fb45ea0bb944b2f
merge base: dfa4a8fe2c9240dd8c4f23f6f69ffb70ad60fa52
target head (main): 85375051b0e4ec9663ef0d722844bf937263b5db
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
ci-run-draft Run CI on draft pull requests
List of changed files detected by CI (4)
scripts
│  ├── pip-audit-whitelist.yml
│  ├── requirements-ci.txt
│  ├── requirements-extra.txt
│  │ requirements-fixed.txt

Outputs:

Toolchain

Version: 69ce670fbd
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:69ce670fbd_a140d687bb

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 3
  • ✅ Integration tests
    • ✅ test-sdk-audio - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ desktop52_verification - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-apps_nrfdesktop - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-apps - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test_ble_nrf_config - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-ble_mesh - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-ble_samples - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nfc - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_libmodem-nrf - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_samples
    • ✅ test-fw-nrfconnect-nrf-iot_lwm2m - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf_crypto - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-rpc - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-rs - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-fem - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-tfm - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-thread-main - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-find-my - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf_lrcs_mosh - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf_lrcs_positioning - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-wifi - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-wifi-net - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-low-level - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-mcuboot
    • ✅ test-sdk-dfu - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-ps-main - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-secdom-samples-public - Skipped: Job was skipped as it succeeded in a previous run

Note: This message is automatically posted and updated by the CI

@NordicBuilder

Copy link
Copy Markdown
Contributor

Memory footprint analysis revealed the following potential issues

applications.hpf.gpio.icmsg[nrf54l15dk/nrf54l15/cpuflpr]: High RAM usage: 9384[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.icmsg[nrf54l15dk/nrf54l15/cpuflpr]: High ROM usage: 6128[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.icbmsg[nrf54l15dk/nrf54l15/cpuflpr]: High RAM usage: 13056[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.icbmsg[nrf54l15dk/nrf54l15/cpuflpr]: High ROM usage: 9792[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.mbox[nrf54l15dk/nrf54l15/cpuflpr]: High RAM usage: 7226[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.mbox[nrf54l15dk/nrf54l15/cpuflpr]: High ROM usage: 3982[B] - link (cc: @nrfconnect/ncs-ll-ursus)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-30555/3)

@jangalda-nsc
jangalda-nsc merged commit cb3accf into nrfconnect:main Aug 7, 2026
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants