[nrf noup] crypto: Add CCM* no tag cipher tests - #12
Open
sigvartmh wants to merge 1 commit into
Open
Conversation
Add PSA_ALG_CCM_STAR_NO_TAG coverage to the psa_cipher_encrypt (c050) and psa_cipher_finish (c037) tests, with vectors in the shared crypto test data, and enable ARCH_TEST_CCM_STAR_NO_TAG for the nRF54L TF-M targets. The test cases are ported from a module that TF-M does not support, so they cannot be picked from the version of the suite TF-M builds against, and have to live downstream for now. Short lived noup: it can be removed once we are able to sync with upstream and take this coverage from there instead. Signed-off-by: Sigvart Hovland <sigvart.hovland@nordicsemi.no>
tomi-font
reviewed
Aug 20, 2026
tomi-font
left a comment
tomi-font
left a comment
Collaborator
There was a problem hiding this comment.
In the commit message can you point to the upstream commit which adds what you're adding?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PSA_ALG_CCM_STAR_NO_TAG coverage to the psa_cipher_encrypt (c050) and psa_cipher_finish (c037) tests, with vectors in the shared crypto test data, and enable ARCH_TEST_CCM_STAR_NO_TAG for the nRF54L TF-M targets.
The test cases are ported from a module that TF-M does not support, so they cannot be picked from the version of the suite TF-M builds against, and have to live downstream for now.
Short lived noup: it can be removed once we are able to sync with upstream and take this coverage from there instead.