Bump dtolnay/rust-toolchain from 3c5f7ea28cd621ae0bf5283f0e981fb97b8a7af9 to 67ef31d5b988238dd797d409d6f9574278e20537#1
Open
dependabot[bot] wants to merge 8 commits into
Conversation
Drop the crate and item rustdoc, the missing_docs and broken-intra-doc lints, and the rustdoc CI job. Docs are written at release prep, not during early development.
Positional Vec -> Vec output cannot detect reordering and misdelivers results silently. A key-addressed map makes violations detectable: a missing key is addressable (Error::MissingOutput), an unknown key fails the whole batch (Error::ContractViolation).
Buffers items and closes a batch on whichever comes first, max_batch_size or a per-window timer. The boundary is resolved in one biased select, so an item arriving as the timer fires goes to the next window, never lost or duplicated.
A closed window collapses to one downstream call: inputs sharing a key dedup to a single representative, and the result fans out by key to every waiting caller. The absence contract is resolved in one place - an unknown response key fails the whole batch and takes precedence over a missing key, which is addressed only to its own waiters. Not wired to a public loader yet, so the entry point is allow(dead_code) until the runtime drives it.
load() drops each request into the collection window and awaits a one-shot reply. A background dispatcher turns every closed window into one deduplicated downstream call and fans the results back out by key, so duplicate keys cost a single call. The loader is cheaply cloneable and its tasks wind down when the last clone is dropped. A torn-down pipeline (for example a downstream panic) surfaces to callers as Error::Closed rather than a silent hang. Spawning the background tasks needs the tokio rt feature.
load is now an inherent async fn borrowing &self, so spawning a concurrent load needs a loader clone. BatchCollector gains a Clone bound, which drops the Arc wrapper in favor of a derived Clone and a spawn constructor. Error moves to thiserror with the same Display texts and source() chain.
Bumps [dtolnay/rust-toolchain](https://github.com/dtolnay/rust-toolchain) from 3c5f7ea28cd621ae0bf5283f0e981fb97b8a7af9 to 67ef31d5b988238dd797d409d6f9574278e20537. - [Release notes](https://github.com/dtolnay/rust-toolchain/releases) - [Commits](dtolnay/rust-toolchain@3c5f7ea...67ef31d) --- updated-dependencies: - dependency-name: dtolnay/rust-toolchain dependency-version: 67ef31d5b988238dd797d409d6f9574278e20537 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
Author
|
A newer version of dtolnay/rust-toolchain exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps dtolnay/rust-toolchain from 3c5f7ea28cd621ae0bf5283f0e981fb97b8a7af9 to 67ef31d5b988238dd797d409d6f9574278e20537.
Commits
67ef31dUpdate actions/checkout@v6 -> v7Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)