Fix up braille deprecations#20458
Merged
Merged
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Collaborator
|
@SaschaCowley Thanks for taking this! |
Contributor
|
I noticed that there are still some deprecation warnings in the logs. |
Member
|
That's okay - several smaller PRs that tackle these individually is much easier to review |
…, getSerialPorts, RENAMED_DRIVERS}
…NGEDCONTEXT, CONTEXTPRES_FILL, CONTEXTPRES_SCROLL, CONTINUATION_SHAPE, CURSOR_SHAPES, TEXT_SEPARATOR, focusContextPresentations}
…d, filter_displayDimensions, filter_displaySize, pre_writeCells}
SaschaCowley
force-pushed
the
braille-deprecations
branch
from
July 9, 2026 10:04
09160f5 to
ddb470f
Compare
Member
Author
|
I believe this is done, pending system tests |
Collaborator
|
I'm not sure how to review this properly, at first sight this looks good to me. |
seanbudd
added
the
conceptApproved
Contributor
|
Can this PR be merged as soon as possible? |
seanbudd
approved these changes
Jul 16, 2026
SaschaCowley
marked this pull request as draft
July 16, 2026 02:00
SaschaCowley
marked this pull request as ready for review
July 16, 2026 02:07
SaschaCowley
enabled auto-merge (squash)
July 16, 2026 02:08
Contributor
|
@SaschaCowley, Due to a system test failure, automatic merging is not possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #20431
Follow-up to #20390
Summary of the issue:
In #20252,
source/braille.pywas split into thesource/braille/package. In #20390, the moved symbols were marked as deprecated. Internal code that uses these symbols was not updated to use the new paths, so logs are being flooded with deprecation warnings.Description of user facing changes:
None.
Description of developer facing changes:
NVDA's logs should once again be useable.
Description of development approach:
Marked the
tests.unit.test_braille.test_publicSurface.TestBraillePublicSurface.test_deprecatedNamesReturnCorrectObjecttest as skipped.For each symbol in:
source/andtests/) for that symbol.Testing strategy:
Unit and system tests.
Known issues with pull request:
None known.
Code Review Checklist: