Skip to content

Steps to run Build NVDAController client and Create NVDA launcher sep…#20507

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
wmhn1872265132:Fixup-parallel
Jul 16, 2026
Merged

Steps to run Build NVDAController client and Create NVDA launcher sep…#20507
seanbudd merged 1 commit into
nvaccess:masterfrom
wmhn1872265132:Fixup-parallel

Conversation

@wmhn1872265132

Copy link
Copy Markdown
Contributor

…arately

Link to issue number:

Summary of the issue:

Occasionally, permission issues may arise when running the Build NVDAController client and Create NVDA launcher steps simultaneously. For safety reasons, they should be run separately

Description of user facing changes:

Description of developer facing changes:

Description of development approach:

Testing strategy:

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@wmhn1872265132
wmhn1872265132 requested a review from a team as a code owner July 16, 2026 01:35
@wmhn1872265132
wmhn1872265132 marked this pull request as draft July 16, 2026 02:19
@seanbudd
seanbudd marked this pull request as ready for review July 16, 2026 02:32
Copilot AI review requested due to automatic review settings July 16, 2026 02:32
@seanbudd
seanbudd merged commit 0e8bed8 into nvaccess:master Jul 16, 2026
40 of 45 checks passed
@github-actions github-actions Bot added this to the 2026.3 milestone Jul 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the Windows CI workflow to avoid intermittent permission/file-access issues by ensuring the “Build NVDAController client” and “Create NVDA launcher” steps are not executed concurrently.

Changes:

  • Replaced a parallel step group containing “Build NVDAController client” and “Create NVDA launcher” with two sequential steps.
  • Keeps the rest of the build/publish workflow behavior intact while prioritizing reliability for these build outputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants