Pass through PKCS11 config - #13
Open
lnksz wants to merge 1 commit into
Open
Conversation
Don't try to be too clever or dictate strict ordering etc. Just let the user pass in his PKCS11 URI. Hint towrads pin-source, to avoid PKCS11 pins directly in the configs
Contributor
|
@lnksz There are multiple reasons to have users follow a strict ordering, one of them being validation of the inputs. With this technique we are reducing the possibilities of errors by validating inputs and the URI thats acceptable to and been validated using CST. We will take inspiration from your contribution, especially related to other acceptable URI parameters, but we will not remove the URI preparation/validation logic. |
Author
|
Of course go the direction you please.
If you wish, I could send PRs for what you would like to change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't try to be too clever or dictate strict ordering, etc. Just let the user pass in his PKCS11 URI.
Hint towards
pin-sourceto avoid PKCS11 pins directly in the configs viapin-valueClose #12