Fix pysaml2 dependency.#15
Merged
Merged
Conversation
Member
|
It looks like they are more error is we upgrade. We cover the CVE but we get new errors in tests. |
avdata99
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a problem in the
pysaml2dependency ofckanext-saml2auth.Root Cause
_lib.GEN_EMAILhas been removedpyopensslin version 49.0 (pyca/pyopenssl@55653a5)_lib.GEN_EMAILfromcryptographyversion 48.0 but version 49.0 is installedpyOpenSSL==24.2.1pysaml2==7.5.4pysaml2does not pin upper version"cryptography >=3.1",pysaml2dependencies are wrong sincepyopenssl<24.3.0will not work with latestcryptography:https://github.com/IdentityPython/pysaml2/blob/master/pyproject.toml
Possible Fix
Looks like this has been addressed in IdentityPython/pysaml2#1021 but it is waiting to be merged.
It has been tested here (look at the
pyproject.tomlfile) : italia/iam-proxy-italia@v3.1.1...v3.2.0Error