Skip to content

fix #2758, fix #2742: implement year and season search filters#3023

Open
MasenWen wants to merge 4 commits into
open-ani:mainfrom
MasenWen:codex-search-zoom-playback-fixes
Open

fix #2758, fix #2742: implement year and season search filters#3023
MasenWen wants to merge 4 commits into
open-ani:mainfrom
MasenWen:codex-search-zoom-playback-fixes

Conversation

@MasenWen

Copy link
Copy Markdown

Summary

This PR adds time-based search filters and several desktop/player UX improvements.

Search

  • add year and season filters to subject search
  • place the time filter controls alongside the existing search filters in the search UI
  • support anime season semantics for:
    • January season
    • April season
    • July season
    • October season
  • wire the selected year/season through search state and repository query building

Player / Desktop UX

  • add global desktop zoom controls with:
    • Ctrl + Mouse Wheel
    • Ctrl + +
    • Ctrl + -
  • prevent windowed mode from shrinking below the normal scale
  • improve close request handling for the desktop window

Playback Speed

  • keep preset playback speeds up to 2x
  • add custom playback speed input
  • support values from 0.1x to 5.0x
  • validate custom input to one decimal place
  • keep the controller visible while the custom speed dialog is open
  • fix incorrect custom speed normalization

Media Source Selection

  • add a persisted hide dead web sources preference
  • update source visibility based on the existing source status detection
  • keep the currently selected source visible even when dead-source filtering is enabled
  • refresh source visibility together with source retesting

Notes

  • the search keyboard navigation out-of-bounds fix is intentionally not included in the issue scope here, since that issue is already being handled separately
  • custom playback speed UI was implemented in a separate component to avoid destabilizing the original progress/controller implementation

Manual Testing

  • verified search year/season filtering behavior
  • verified desktop zoom shortcuts
  • verified playback speed preset and custom input behavior
  • verified custom speed dialog no longer closes unexpectedly during interaction
  • verified dead-source filtering toggle and refresh behavior

Build Verification

  • :app:desktop:compileKotlin

@StageGuard

Copy link
Copy Markdown
Member

一个 PR 里只能有一个功能,建议拆一下

@Him188 Him188 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

辛苦把 PR 里无关修改去除 / 拆成别的 PR

icon = appIcon,
tooltip = "Ani",
onExit = ::exitApplication,
onExit = requestExit,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这块好像是无关修改

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我尝试拆一下 不过以前的相关issue非常混乱 我可能不能包含的很清楚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants