Reorganized PRs 3/4: Add 2.5x & Custom playback speed (#3026)#3030
Open
MasenWen wants to merge 2 commits into
Open
Reorganized PRs 3/4: Add 2.5x & Custom playback speed (#3026)#3030MasenWen wants to merge 2 commits into
MasenWen wants to merge 2 commits into
Conversation
Him188
reviewed
May 22, 2026
| ) | ||
| } | ||
| DropdownMenuItem( | ||
| text = { Text("Custom") }, |
| val playbackSpeedAlwaysOnRequester = | ||
| rememberAlwaysOnRequester(playerControllerState, "speedSwitcher") | ||
| playbackSpeedControllerState?.also { controller -> | ||
| SpeedSwitcher(controller) { |
Member
|
是否有测试过? 确认大于 3 的倍速能流畅播放吗? 之前测试是不行的, 缓冲区不够, 可能还需要同步更新缓冲区大小 |
Member
|
请提供 UI 效果图 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3026.
Also covers #2780 and #2302.
Summary
Validation
:app:shared:video-player:desktopTest --tests "*PlaybackSpeedControllerStateTest":app:shared:video-player:compileKotlinDesktopNotes
:app:shared:compileKotlinDesktopwas retried, but the rerun hit a Gradle/Kotlin daemon environment issue after module compilation had already progressed. The player-specific test and module compilation passed.