feat(codereadiness): prepare Code Readiness hook specification#405
feat(codereadiness): prepare Code Readiness hook specification#405marcin11858 wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis change adds a new "Code Readiness Hook" specification section to Appendix A, defining requirements for a hook that blocks feature flag activation on binaries below a minimum code version specified in flag metadata, including lifecycle behavior, initialization, and configurable comparison strategy. ChangesDocumentation Addition
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3b523f0 to
76b6397
Compare
Signed-off-by: Marcin Wlazły <marcinwlazly@google.com>
76b6397 to
3ee0571
Compare
|
|
|
I can see you are implementing this in a few repos. I'm quite curious about it. Copy pasting my question from here:
I'm not fundamentally opposed to this, but I want to make sure I understand the use case before we add this to the spec - we don't have many hooks in the spec. If we do want to spec it, we also may want to consider including it in the base SDK - but that's a separate question. |
Thank you for your question. I found two possible use cases: working on a complex task: The developer introduced reading feature flag in one of the PR but there is more PRs in a queue which are waiting for a review. When all PRs will be merge the code is ready and new feature can be enable safety. |
This PR
Describes specification of the Code Readiness Hook. The Hook will prevent enabling a feature flag in running binaries that are not ready
Follow-up Tasks
None