Make sure output is treated consistently in R2SManager#3994
Merged
Conversation
pshriwise
approved these changes
Jul 5, 2026
pshriwise
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me as well @paulromano. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small PR here to fix unwanted output behavior when carrying out R2S runs with
R2SManager:openmc.lib.TemporarySession) was shown. This is fixed by passingoutput=FalsetoTemporarySessionrun_kwargs. Now it is handled consistently: if the user callsmanager.run(run_kwargs={'output': True})they will see output and if they callmanager.run(run_kwargs={'output': False})they will not see output.Checklist
I have run clang-format (version 18) on any C++ source files (if applicable)I have added tests that prove my fix is effective or that my feature works (if applicable)