Registration page label fixes - #2657
Conversation
…abel
The config framework backfills label with "" (not undefined) for gender
options that don't specify one, since the elements schema defines
label: {_default: ""}. gender-field.component.tsx used ?? when falling
back to option.value, which only catches null/undefined, so labelText
resolved to t("", "") and Carbon's RadioButton rendered no label text at
all. Switched to || so an empty string also falls back to option.value.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Restore work that only existed as uncommitted changes in a local clone and was lost when that clone was reset, using the copy preserved in openmrs-distro-referenceapplication's frontend/esm-patient-registration-app-patched: - config-schema.ts: add selectFields config for rendering an address field as a dropdown (used for the Governorate/State-Province field) - address-field.component.tsx: render a SelectInput when a field has selectFields options configured, instead of always rendering free text - patient-registration.component.tsx: wire through the address select field options - validation/luhn.ts: Luhn checksum validator - validation/patient-registration-validation.ts: validate the National ID address field against its configured Luhn/regex rules Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Adds a fifth tab alongside Starred/System/My/All lists that shows every registered patient, not just ones added to a list, so staff can find and navigate to any patient even if they were never added to a cohort. - useAllPatients hook queries the FHIR2 Patient search endpoint (the core REST /patient resource doesn't support listing without a search term), with pagination and an optional name filter. - AllPatientsTable renders a searchable, paginated table; clicking a patient's name navigates to their chart, same pattern as the existing list-details table. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Greptile SummaryThis change expands registration configuration and address validation, adds a default patient-status field, and introduces an all-patients dashboard view backed by FHIR search. Two failures were reproduced. The Luhn validator accepts values containing letters and punctuation when the remaining digits satisfy the checksum, and the all-patients table presents failed patient requests as an empty result set. The default patient-status metadata concern was disproved by an executed render-and-submit check: when the optional person-attribute type is unavailable, the field shows its fetch error but registration can still be submitted without a patient-status attribute. Merge is not safe until the validation and patient-list error handling issues are resolved.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| const digits = value.replace(/\D/g, ''); | ||
| if (!digits) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
isValidLuhn removes all non-digits before calculating the checksum, so a configured address value such as 799-ABC273!98713 is accepted because its sanitized digits form a valid Luhn number. Reject values containing non-digit characters before performing the checksum so malformed identifiers cannot be saved.
Artifacts
Executable Luhn contamination harness source
- Vitest harness imports and calls the production Luhn validator with the baseline and contaminated inputs; it is the executable test used to obtain the observed results.
Baseline Luhn validation output
- Executed Vitest baseline run from `/home/user/repo` shows `79927398713` returned true and exited 0, establishing the valid-digit control.
Contaminated Luhn validation output
- Executed Vitest contaminated-input run from `/home/user/repo` shows `799-ABC273!98713` returned true and exited 0, confirming the validator accepts letters and punctuation.
| const { patients, totalPatients, isLoading, isValidating } = useAllPatients( | ||
| (currentPage - 1) * currentPageSize, | ||
| currentPageSize, | ||
| debouncedSearchTerm, | ||
| ); |
There was a problem hiding this comment.
When useAllPatients completes with an error and no rows, this component ignores the hook's error value and falls through to “There are no patients to display.” This hides server and connectivity failures from users. Render a dedicated error state before the empty-list fallback.
Artifacts
FHIR Patient request-error UI harness source
- Authored Vitest harness mocks a completed FHIR Patient HTTP-500-style error and asserts the rendered empty-state output, confirming the exact path.
FHIR Patient request-error UI harness output
- Executed `yarn vitest run trex-artifacts/all-patients-request-error.test.tsx --config packages/esm-patient-list-management-app/vitest.config.ts` from `/home/user/repo` and recorded one passing assertion, confirming the path.
▶ Normal empty patient-list state in Chromium
- Chromium rendered the no-data state for the component and showed “There are no patients to display,” establishing the normal empty-state baseline.
▶ Failed FHIR Patient request state in Chromium
- Chromium rendered the completed FHIR request-error output and showed the same “There are no patients to display” empty state, confirming the defect.
Chromium capture command output
- Executed the Playwright Chromium capture harness from `/home/user/repo` with exit code 0 and produced the comparison videos and poster frames, confirming captured UI evidence.
2 participants
No description provided.