Build for illumos, and keep customer identifiers out of the repo - #9
Merged
Conversation
Adds x86_64-unknown-illumos as a cross-compilation target (official cross-rs image) and to the release matrix. tvision-rs's os-clipboard feature is dropped on illumos only, because arboard pulls in Wayland, which does not build there; the OSC 52 clipboard path remains, which is the one that works over ssh anyway. Also removes a customer's identifiers from tracked files. They had reached the published mdBook and a unit test, while the corresponding config file was already gitignored for exactly that reason. The stale controller handoff was entirely customer-operational and is dropped; its content moves to a private wiki. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
illumos support
eDAPtor now cross-compiles for
x86_64-unknown-illumos(OmniOS and friends),using the official
cross-rsimage. Verified end to end: the binary was built,installed on an illumos host, and runs there against a live OpenLDAP 2.4.48
directory (
edaptor checkreturns a full subschema).Cross.tomlgains the target. The image tag is pinned while the musltargets float on
:main— deliberate, and commented so it isn't "fixed".Cargo.tomlselectstvision-rsper target: illumos takesdefault-features = false, every other platform is untouched. This is neededbecause the default
os-clipboardfeature pullsarboard -> wl-clipboard-rs -> wayland-backend, and Wayland does not compileon illumos. The OSC 52 clipboard rung remains — the one that actually works
over ssh, which is how a TUI on such a host is driven anyway.
release.ymlgains the target.RUSTFLAGSmoves into the matrix so eachtarget carries its own: the two musl targets keep
-C target-feature=+crt-static, illumos gets none. illumos has no static libc,so the previous blanket flag would have broken it.
No
.rsbehaviour changes.make checkis green (fmt, clippy-D warnings, tests).Customer identifiers
A customer's directory identifiers had reached tracked files — including the
published mdBook and a unit test — even though the corresponding config file
was already in
.gitignorefor exactly that reason. This removes them and addsthe second such config to
.gitignore.docs/controller-handoff.mdis deleted rather than sanitized: it was entirelycustomer-operational (host names, deploy recipes, config paths). Its content has
been migrated to a private wiki, and
CLAUDE.mdalready calls for a freshhandoff to be written at each rollover.
🤖 Generated with Claude Code