Add experimental PHPantom lsp support for PHP - #1554
Merged
Conversation
improved implementation Add PHPantom hover fallback and tests fix phpantom binary download on linux and macos
Member
|
@cappuc looks good, the AI did a sufficiently good job here. Merging, apologies for the late reaction. Thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PHPantom is a new language server for PHP written in rust that provides better performance and lower resource utilization that other solutions.
Note
This implementation is done with AI assistance since I'm not a python export. I hope the code is good enough.
I've been testing serena with
php_phpantomfor a few days on real projects and it seems to work well.Changes
php_phpantomas an experimental PHP language backend powered byPHPantom-dev/phpantom_lsp.Testing