Stabilize Rust diagnostics retrieval across CI platforms - #1559
Stabilize Rust diagnostics retrieval across CI platforms#1559MischaPanch with Copilot wants to merge 5 commits into
Conversation
|
@copilot the error appears in all platforms, not just windows. You should also explain how the error is related to recent changes to our rust LS support |
Addressed in I changed Rust Analyzer to use the extended published-diagnostics wait timeout on all platforms (not only Windows), and updated the timeout test to cover both Windows and Linux. Why this is tied to recent Rust LS changes: after the recent diagnostics-flow updates in |
TestRustDiagnostics::test_file_diagnosticswas intermittently failing because Rust diagnostics can arrive after the default wait window, producing an empty result (AssertionError: []). While it was first observed onwindows-latest, the timing issue can occur on other platforms too. This change makes Rust diagnostics waiting more tolerant across platforms.This is related to recent Rust LS diagnostics flow changes: diagnostics retrieval now relies on pull diagnostics first and then falls back to waiting for
publishDiagnosticswhen pull results are empty, so delayed published diagnostics can miss the shorter default window.Diagnostics timeout behavior (Rust Analyzer)
>= 8s).Regression coverage