tools: name custom app packages so they survive a release upload

create-app-{linux,macos,windows}.sh named their output after APP_NAME
verbatim. For any app whose name has a space, GitHub rewrites the space
to a dot when the file is uploaded as a release asset, so what CI
produces and what users download are two different file names.

That silently broke the Linux launcher: create-app-linux.sh writes a
.sh next to the AppImage that execs it by name, so every published
launcher pointed at a file that does not exist under that name. Four
sat-mtl apps ship one today, all dead:

  exec "$SCRIPT_DIR/Spatial Protocol Mapper-linux-x86_64.AppImage"
  # asset is actually Spatial.Protocol.Mapper-linux-x86_64.AppImage

Use APP_NAME_SAFE for the file names, which create-app.sh already
derives and create-app-wasm.sh already uses. APP_NAME still names the
app itself: the .desktop entry, the DMG volume, the window title.

Also make --qml absolute the way --score and --local-installer already
are. The platform scripts cd into their work directory before copying,
so a relative --qml resolved to nothing there and the copy is guarded
with `|| true` -- the app was packaged with an empty qml directory and
no error. Only reachable from the command line: the package-custom-app
action passes absolute paths already.

Verified by packaging a wasm bundle with a relative --qml and a name
with spaces: the qml now arrives, and the output is
Spatial-Protocol-Mapper-wasm.zip.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VxtUwsfk4JN46WropbwfqC

Author: jcelerier

tools/create-app-linux.sh

@@ -231,7 +231,7 @@ fi
 
 # Repackage the AppImage
 echo "Repackaging AppImage..."
-OUTPUT_APPIMAGE="${APP_NAME}-${PLATFORM}.AppImage"
+OUTPUT_APPIMAGE="${APP_NAME_SAFE}-${PLATFORM}.AppImage"
 
 ./appimagetool-${ARCH}.AppImage -n squashfs-root "$OUTPUT_APPIMAGE" \
     --runtime-file "runtime-${ARCH}"
@@ -249,13 +249,13 @@ mv "$OUTPUT_APPIMAGE" "$OUTPUT_DIR/"
 echo "✓ Created: $OUTPUT_DIR/$OUTPUT_APPIMAGE"
 
 # Create a simple run script
-cat > "$OUTPUT_DIR/${APP_NAME}-${PLATFORM}.sh" << EOF
+cat > "$OUTPUT_DIR/${APP_NAME_SAFE}-${PLATFORM}.sh" << EOF
 #!/bin/bash
 # Launcher script for ${APP_NAME}
 SCRIPT_DIR="\$(cd "\$(dirname "\${BASH_SOURCE[0]}")" && pwd)"
 exec "\$SCRIPT_DIR/$OUTPUT_APPIMAGE" "\$@"
 EOF
 
-chmod +x "$OUTPUT_DIR/${APP_NAME}-${PLATFORM}.sh"
+chmod +x "$OUTPUT_DIR/${APP_NAME_SAFE}-${PLATFORM}.sh"
 
 echo "✓ Linux package created successfully"

tools/create-app-macos.sh

@@ -366,7 +366,7 @@ fi
 
 # Create a DMG
 echo "Creating DMG..."
-OUTPUT_DMG="${APP_NAME}-${PLATFORM}.dmg"
+OUTPUT_DMG="${APP_NAME_SAFE}-${PLATFORM}.dmg"
 
 # Simple method using hdiutil
 rm -f "$OUTPUT_DMG"

tools/create-app-windows.sh

@@ -208,7 +208,7 @@ cd "$WORK_DIR"
 
 # Create a ZIP package
 echo "Creating ZIP package..."
-OUTPUT_ZIP="${APP_NAME}-windows.zip"
+OUTPUT_ZIP="${APP_NAME_SAFE}-windows.zip"
 
 if command -v zip &> /dev/null; then
     (cd "$INSTALL_DIR" && zip -r -q "$WORK_DIR/$OUTPUT_ZIP" .)

tools/create-app.sh

@@ -100,9 +100,9 @@ while [[ $# -gt 0 ]]; do
     case $1 in
         --qml)
             if [[ -f "$2" ]]; then
-                QML_FILES+=("$2")
+                QML_FILES+=("$(cd "$(dirname "$2")" && pwd)/$(basename "$2")")
             elif [[ -d "$2" ]]; then
-                QML_DIRS+=("$2")
+                QML_DIRS+=("$(cd "$2" && pwd)")
             else
                 echo "Error: QML path does not exist: $2"
                 exit 1