Skip to content

Fix missing request context (cookies/headers) in WebSocket callbacks#3815

Open
i-murray wants to merge 4 commits into
plotly:devfrom
i-murray:fix/websocket-callback-request-context
Open

Fix missing request context (cookies/headers) in WebSocket callbacks#3815
i-murray wants to merge 4 commits into
plotly:devfrom
i-murray:fix/websocket-callback-request-context

Reuse set_current_request machinery for WebSocket callback context

3795bc4
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jun 18, 2026 in 42s

Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
2 Security Hotspots
0.0% Coverage on New Code
15.3% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check failure on line 58 in tests/websocket/test_ws_context.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change this argument; Function "create_ws_context" expects a different type 

See more on https://sonarcloud.io/project/issues?id=plotly_dash&issues=AZ67Ff_7YiCndbFqAufV&open=AZ67Ff_7YiCndbFqAufV&pullRequest=3815

Check warning on line 30 in tests/websocket/test_ws_context.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make sure using this hardcoded IP address "10.0.0.1" is safe here. 

See more on https://sonarcloud.io/project/issues?id=plotly_dash&issues=AZ7b_e5LtKpssLwAZNpG&open=AZ7b_e5LtKpssLwAZNpG&pullRequest=3815

Check warning on line 94 in tests/websocket/test_ws_context.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make sure using this hardcoded IP address "10.0.0.1" is safe here. 

See more on https://sonarcloud.io/project/issues?id=plotly_dash&issues=AZ7b_e5LtKpssLwAZNpI&open=AZ7b_e5LtKpssLwAZNpI&pullRequest=3815

Check failure on line 117 in tests/websocket/test_ws_context.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change this argument; Function "create_ws_context" expects a different type 

See more on https://sonarcloud.io/project/issues?id=plotly_dash&issues=AZ7b_e5LtKpssLwAZNpJ&open=AZ7b_e5LtKpssLwAZNpJ&pullRequest=3815

Check failure on line 37 in tests/websocket/test_ws_context.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change this argument; Function "create_ws_context" expects a different type 

See more on https://sonarcloud.io/project/issues?id=plotly_dash&issues=AZ7Ko_3TG5ZcitlriqK9&open=AZ7Ko_3TG5ZcitlriqK9&pullRequest=3815

Check warning on line 128 in tests/websocket/test_ws_context.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make sure using this hardcoded IP address "10.0.0.1" is safe here. 

See more on https://sonarcloud.io/project/issues?id=plotly_dash&issues=AZ7b_e5LtKpssLwAZNpL&open=AZ7b_e5LtKpssLwAZNpL&pullRequest=3815

Check warning on line 45 in tests/websocket/test_ws_context.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make sure using this hardcoded IP address "10.0.0.1" is safe here. 

See more on https://sonarcloud.io/project/issues?id=plotly_dash&issues=AZ67Ff_7YiCndbFqAufU&open=AZ67Ff_7YiCndbFqAufU&pullRequest=3815
View more details on SonarQubeCloud