Conversation
|
This PR introduces changes that may not work on all browsers. According to Babel, the following polyfills may be needed, and they are not automatically included:
The best way to address this is to provide good test coverage, as normal PR checks run unit tests on older browsers. |
|
Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 02abf3244b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
This PR introduces changes that may not work on all browsers. According to Babel, the following polyfills may be needed, and they are not automatically included:
The best way to address this is to provide good test coverage, as normal PR checks run unit tests on older browsers. |
Barecheck - Code coverage reportTotal: 96.56%Your code coverage diff: 0.00% ▴ Uncovered files and lines
|
|
This PR introduces changes that may not work on all browsers. According to Babel, the following polyfills may be needed, and they are not automatically included:
The best way to address this is to provide good test coverage, as normal PR checks run unit tests on older browsers. |
Type of change
Description of change
This adds some tooling to load prebid from a CDN in a way that should be compatible with cross origin storage. The build now generates:
prebid.web.js: this is intended as a drop-in replacement for the "normal"prebid.jsbundle. Instead of being a concatenation of chunks selected with the build's--modules, it contains only the names and checksums of those chunks, and adds correspoding<script>tags to load them from a CDN (by default this ishttps://cdn.jsdelivr.net/npm/prebid.js@<version>/dist/chunks/, controllable with--distUrlBase).Note that the default
distUrlBasepoints to a specific version only when building a tagged version (the version inpackage.jsondoes not end with '-pre'). When building master it points tolatest, which is unlikely to have matching checksums; the generatedprebid.web.jswould fail to load in that case.bundle.js: this is intended to be loaded directly from a CDN. Once released, publishers should be able to load prebid withmodules, then adding a <script> tag for each chunk.It supports setting the
globalVarNameanddistUrlBasebuild options (e.g.bundle.js?globalVarName=customGlobal), but notdefineGlobal, as a global variable is the only way to interact with Prebdi when loaded this way.Other information
Closes #15256