Skip to content

CI - Fix spellcheck and Flake8 failures affecting all pull requests - #355

Open
raul-marquez-csa wants to merge 2 commits into
project-chip:mainfrom
raul-marquez-csa:th-ci-lint-spellcheck-fix
Open

CI - Fix spellcheck and Flake8 failures affecting all pull requests#355
raul-marquez-csa wants to merge 2 commits into
project-chip:mainfrom
raul-marquez-csa:th-ci-lint-spellcheck-fix

Conversation

@raul-marquez-csa

@raul-marquez-csa raul-marquez-csa commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes an issue where the spellcheck and Flake8 CI jobs failed on every pull request regardless of its content (the cspell dictionary was missing five code identifiers used in tracked files, Flake8 linted the python_tests submodule content, which carries long lines in tcdd13.py and is maintained in its own repository, and the spellcheck workflow ran on pull_request_target with a default checkout, so PR runs scanned the base branch instead of the PR), by adding the identifiers to the cspell ignoreWords list, ignoring E501 for the submodule path in the Flake8 configuration, and triggering the spellcheck workflow on pull_request so it checks out and scans the PR content.

Included in this PR

  • Added astext, asname, TLSCERT, JFADMIN and AABBCCDD to the spellcheck ignore list (cspell.json)
  • Ignored E501 for the python_tests submodule path, following the existing per-file-ignores entries for other test collections (.flake8)
  • Changed the spellcheck workflow trigger from pull_request_target to pull_request so PR runs check out and scan the PR content instead of the base branch (spell-check.yml)

Note for reviewers: the spellcheck check on this PR stays red because pull_request_target runs use the base branch's workflow definition and tree; all three fixes take effect once merged.

Testing

Flake8 with the repository configuration (9 pre-existing violations before the change, none after)

python -m flake8 .

Related issues

[Link to issue the PR addresses]

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@raul-marquez-csa, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 35 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 922192cb-8be4-444e-87b1-adf86600e462

📥 Commits

Reviewing files that changed from the base of the PR and between 5c1b9ac and 3ce0466.

📒 Files selected for processing (3)
  • .flake8
  • .github/workflows/spell-check.yml
  • cspell.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant