CI - Fix spellcheck and Flake8 failures affecting all pull requests - #355
CI - Fix spellcheck and Flake8 failures affecting all pull requests#355raul-marquez-csa wants to merge 2 commits into
Conversation
|
Warning Review limit reached
Next review available in: 35 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Fixes an issue where the spellcheck and Flake8 CI jobs failed on every pull request regardless of its content (the cspell dictionary was missing five code identifiers used in tracked files, Flake8 linted the
python_testssubmodule content, which carries long lines intcdd13.pyand is maintained in its own repository, and the spellcheck workflow ran onpull_request_targetwith a default checkout, so PR runs scanned the base branch instead of the PR), by adding the identifiers to the cspellignoreWordslist, ignoringE501for the submodule path in the Flake8 configuration, and triggering the spellcheck workflow onpull_requestso it checks out and scans the PR content.Included in this PR
astext,asname,TLSCERT,JFADMINandAABBCCDDto the spellcheck ignore list (cspell.json)E501for thepython_testssubmodule path, following the existingper-file-ignoresentries for other test collections (.flake8)pull_request_targettopull_requestso PR runs check out and scan the PR content instead of the base branch (spell-check.yml)Note for reviewers: the spellcheck check on this PR stays red because
pull_request_targetruns use the base branch's workflow definition and tree; all three fixes take effect once merged.Testing
Flake8 with the repository configuration (9 pre-existing violations before the change, none after)
Related issues
[Link to issue the PR addresses]