Skip to content

Add nfc-ethernet to PairingMode and DutPairingModeEnum - #108

Open
rquidute wants to merge 1 commit into
v2.16-cli-developfrom
feature/1067-nfc-ethernet-python-testing
Open

Add nfc-ethernet to PairingMode and DutPairingModeEnum#108
rquidute wants to merge 1 commit into
v2.16-cli-developfrom
feature/1067-nfc-ethernet-python-testing

Conversation

@rquidute

Copy link
Copy Markdown
Contributor

Summary

Mirrors the backend's nfc-ethernet DUT pairing mode addition so the CLI's enums stay in sync (see project-chip/certification-tool-backend#351).

Changes

  • th_cli/shared_constants.py: added NFC_ETHERNET = "nfc-ethernet" to DutPairingModeEnum and to NFC_PAIRING_MODES.
  • th_cli/config.py: added NFC_ETHERNET to the PairingMode enum (currently unused for validation, kept in sync with the backend enum).
  • tests/test_config.py: added test_nfc_ethernet_value.

Out of scope

  • YAML/chip-tool test support — blocked on upstream connectedhomeip#43613, which is still under review.

Related: project-chip/certification-tool#1067

Mirrors the backend's app/constants/shared_constants.py so the CLI's
enums stay in sync with the new NFC_ETHERNET pairing mode used for
Matter-over-Ethernet commissioning over NFC in python_testing suites.

Related: project-chip/certification-tool#1067
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d3bfb60a-ed06-476f-b85d-18a6605a707c

📥 Commits

Reviewing files that changed from the base of the PR and between 937fc4c and eda7a7f.

📒 Files selected for processing (3)
  • tests/test_config.py
  • th_cli/config.py
  • th_cli/shared_constants.py

Included review availability: Your plan includes up to 3 reviews per rolling hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The PR adds NFC_ETHERNET with the value "nfc-ethernet" to PairingMode and DutPairingModeEnum. It includes the value in NFC_PAIRING_MODES and the derived valid pairing modes. A unit test verifies the configuration value.

Possibly related issues

  • project-chip/connectedhomeip#72975 — Adds explicit support for NFC commissioning of Ethernet devices, matching the testing scenario described by this PR.

Merge Risk: ⚪ Minimal · up to eda7a

This localized change keeps the CLI pairing-mode enums aligned with the backend and adds coverage for the new value; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the addition of nfc-ethernet to both PairingMode and DutPairingModeEnum.
Description check ✅ Passed The description accurately explains the enum updates, test addition, synchronization goal, and out-of-scope items.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@mergify

mergify Bot commented Aug 18, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@rquidute rquidute self-assigned this Aug 18, 2026
@rquidute

Copy link
Copy Markdown
Contributor Author

@coderabbitai review full

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

@rquidute: I will perform a full review of PR #108.

✅ Action performed

Full review finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants