fix: unify label widths when widgets passed to Container constructor#730
Open
tlambert03 wants to merge 1 commit into
Open
fix: unify label widths when widgets passed to Container constructor#730tlambert03 wants to merge 1 commit into
tlambert03 wants to merge 1 commit into
Conversation
Container(widgets=[...]) rendered with different label/control alignment than an empty Container populated with append(). During __init__, widgets are inserted before _initialized is set to True, but _unify_label_widths() is a no-op until _initialized is True, so label widths were never unified for constructor-supplied widgets. Call _unify_label_widths() once after initialization completes. Fixes #729
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #730 +/- ##
=======================================
Coverage 89.27% 89.27%
=======================================
Files 40 40
Lines 4821 4822 +1
=======================================
+ Hits 4304 4305 +1
Misses 517 517 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Container(widgets=[...]) rendered with different label/control alignment
than an empty Container populated with append(). During init, widgets
are inserted before _initialized is set to True, but _unify_label_widths()
is a no-op until _initialized is True, so label widths were never unified
for constructor-supplied widgets.
Call _unify_label_widths() once after initialization completes.
Fixes #729