gh-153027: Make CDATA section parsing in HTMLParser context-dependent#153028
Open
serhiy-storchaka wants to merge 1 commit into
Open
gh-153027: Make CDATA section parsing in HTMLParser context-dependent#153028serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
…endent HTMLParser now follows start and end tags to detect foreign content (the content of "svg" and "math" elements), in accordance with the HTML5 standard. In HTML content, "<![CDATA[...]]>" is now parsed as a bogus comment which ends at the first ">". In foreign content, RAWTEXT and RCDATA elements (such as "script", "style", "title" or "textarea") are now parsed as normal elements. The new "support_cdata" parameter of the constructor allows forcing recognition of CDATA sections in any context (the previous behavior) or in no context. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTMLParser now follows start and end tags to detect foreign content (the content of
svgandmathelements), approximating the tree construction dispatcher and the rules for parsing tokens in foreign content of the HTML5 standard: integration points, breakout tags, self-closing foreign elements.In HTML content,
<![CDATA[...]]>is now parsed as a bogus comment which ends at the first>. In foreign content, RAWTEXT and RCDATA elements (such asscript,style,titleortextarea) are now parsed as normal elements.The new support_cdata parameter of the constructor allows forcing recognition of CDATA sections in any context (the previous default behavior) or in no context. Calling the private method
_set_support_cdata()disables the automatic detection, so existing code which maintains its own tracking machinery inhandle_starttag()andhandle_endtag()works as before.There is no performance impact for parsing HTML content without foreign elements: the stack of open elements is only maintained inside foreign content.