Add cleanup_socket to AbstractEventLoop create_unix_server#15969
Closed
ishaanlabs-gg wants to merge 1 commit into
Closed
Add cleanup_socket to AbstractEventLoop create_unix_server#15969ishaanlabs-gg wants to merge 1 commit into
ishaanlabs-gg wants to merge 1 commit into
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15742.
asyncio.unix_events._UnixSelectorEventLoop.create_unix_serveralready includes the Python 3.13cleanup_socketkeyword, butasyncio.events.AbstractEventLoop.create_unix_serverdid not. This adds the Python 3.13+ keyword there so code typed asAbstractEventLoopcan call the API without a false-positive type error.The abstract runtime signature still lacks the keyword, so the versioned stubtest allowlists document that mismatch while keeping the concrete Unix event-loop signature checked.
Checks run:
PYTHONPATH=lib /Volumes/STOREJET/2/Dependencies/typeshed-venv/bin/python tests/regr_test.py stdlib --python-version 3.13PYTHONPATH=lib /Volumes/STOREJET/2/Dependencies/typeshed-venv/bin/python tests/regr_test.py stdlib --python-version 3.12PYTHONPATH=lib /Volumes/STOREJET/2/Dependencies/typeshed-venv/bin/python tests/mypy_test.py stdlib/asyncio --python-version 3.13PYTHONPATH=lib /Volumes/STOREJET/2/Dependencies/typeshed-venv/bin/python tests/pyright_test.py stdlib/asyncio/events.pyiPYTHONPATH=lib /Volumes/STOREJET/2/Dependencies/typeshed-venv/bin/python tests/check_typeshed_structure.pyPYTHONPATH=lib /Volumes/STOREJET/2/Dependencies/typeshed-venv/bin/python -m mypy.stubtest --show-traceback --strict-type-check-only --custom-typeshed-dir . --ignore-unused-allowlist --allowlist stdlib/@tests/stubtest_allowlists/common.txt --allowlist stdlib/@tests/stubtest_allowlists/darwin.txt --allowlist stdlib/@tests/stubtest_allowlists/py314.txt --allowlist stdlib/@tests/stubtest_allowlists/darwin-py314.txt asyncio.events asyncio.unix_events/Volumes/STOREJET/2/Dependencies/typeshed-venv/bin/python -m ruff format --check stdlib/asyncio/events.pyi stdlib/@tests/test_cases/asyncio/check_events-py313.pygit diff --checkNote:
tests/runtests.py stdlib/asyncio --python-version 3.13reached successful mypy/pyright/regression/structure checks locally, but the all-in-one run was not fully usable in this external-volume checkout: pre-commit hook installation generated AppleDouble._*.dist-infometadata in its hook venv, and full stdlib stubtest also reports unrelated local Python 3.14 runtime mismatches outside asyncio (_curses,annotationlib,pyexpat).