Fix aiofiles NamedTemporaryFile name type#15970
Closed
ishaanlabs-gg wants to merge 1 commit into
Closed
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13551.
aiofiles.tempfile.NamedTemporaryFile()always creates a named temporary file, so its async file object exposesnameas a string path. The generic aiofiles async file wrappers still keep the broaderFileDescriptorOrPathtype for other call sites, but theNamedTemporaryFile()overloads now return named wrapper variants that narrownametostr.Validation:
/Volumes/STOREJET/2/Dependencies/typeshed-venv/bin/python tests/regr_test.py aiofiles --python-version 3.13 --verbosity NORMAL/Volumes/STOREJET/2/Dependencies/typeshed-venv/bin/python tests/mypy_test.py stubs/aiofiles --python-version 3.13/Volumes/STOREJET/2/Dependencies/typeshed-venv/bin/python tests/check_typeshed_structure.pyNPM_CONFIG_CACHE=/Volumes/STOREJET/Documents/OSC/repos/typeshed-aiofiles-name/.npm-cache /Volumes/STOREJET/2/Dependencies/typeshed-venv/bin/python tests/pyright_test.py stubs/aiofiles/aiofiles/tempfile/__init__.pyigit diff --check