fix(quickget): support new kde neon directory structure with editions#1926
fix(quickget): support new kde neon directory structure with editions#1926MightyCoderX wants to merge 2 commits into
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 1 file
Confidence score: 3/5
quickgetappears to accept KDE Neon dev metadata wherePUBLICis returned instead of an ISO filename without validating it, which can produce a bad download/checksum target and break image retrieval for those editions; add explicit handling/validation for non-ISOPUBLICresponses (fail fast or resolve the real ISO URL) before merging.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="quickget">
<violation number="1" location="quickget:2231">
P1: KDE Neon checksum/ISO resolution lacks validation for dev editions that return PUBLIC instead of an ISO filename</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| ISO=$(web_pipe "${URL}/neon-${RELEASE}-current.sha256sum" | cut -d' ' -f3-) | ||
| HASH=$(web_pipe "${URL}/neon-${RELEASE}-current.sha256sum" | cut -d' ' -f1) | ||
| local URL="https://files.kde.org/neon/images/${EDITION}/${RELEASE}/current" | ||
| ISO=$(web_pipe "${URL}/neon-${RELEASE}-${EDITION}-current.sha256sum" | cut -d' ' -f3-) |
There was a problem hiding this comment.
P1: KDE Neon checksum/ISO resolution lacks validation for dev editions that return PUBLIC instead of an ISO filename
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At quickget, line 2231:
<comment>KDE Neon checksum/ISO resolution lacks validation for dev editions that return PUBLIC instead of an ISO filename</comment>
<file context>
@@ -2223,9 +2227,9 @@ function get_kali() {
- ISO=$(web_pipe "${URL}/neon-${RELEASE}-current.sha256sum" | cut -d' ' -f3-)
- HASH=$(web_pipe "${URL}/neon-${RELEASE}-current.sha256sum" | cut -d' ' -f1)
+ local URL="https://files.kde.org/neon/images/${EDITION}/${RELEASE}/current"
+ ISO=$(web_pipe "${URL}/neon-${RELEASE}-${EDITION}-current.sha256sum" | cut -d' ' -f3-)
+ HASH=$(web_pipe "${URL}/neon-${RELEASE}-${EDITION}-current.sha256sum" | cut -d' ' -f1)
echo "${URL}/${ISO} ${HASH}"
</file context>
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.
Re-trigger cubic
|
Since the So there needs to be a check somewhere else, and since I don't know where it would be the proper place to put this very specific check, without changing too much of the code, I haven't done it yet. If someone more familiar with the code base could point out the best solution, I would be glad. |
1 participant
Description
KDE Neon download link was broken since they now have a different directory structure.
I considered their new division based on devices like an edition and added support for editions by adding the
editions_kdeneonfunction and updating theget_kdeneonfunction to build the correct iso and hash urls according to the new directory structure and file names../quickemu --url kdeneon./quickget --check kdeneonWhat would be a clean way to fix those two failing ones (kdeneon-user-dev, kdeneon-testing-dev)?
./quickget --check-all-archI tested getting the image and running a vm (kdeneon unstable desktop) and it boots fine.
For the changes i looked at how you handled similar stuff and I tried to make the change properly, if something is off tell me and I'll fix it!
Type of change
Checklist: