Menu: Fix pointer transfer to collision-flipped submenus - #4037
Open
wanxiankai wants to merge 1 commit into
Open
Menu: Fix pointer transfer to collision-flipped submenus#4037wanxiankai wants to merge 1 commit into
wanxiankai wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: b3fadf0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
chaance
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #4036
When a submenu collision-flips, a coalesced pointer move can reach the submenu before another
pointermoveupdatespointerDirRef. The stale direction makes the grace-area check fail and moves focus back to the parent menu, allowing React 19 to unmount the submenu before the queued click lands.This change derives the direction from the latest
pointerleavecoordinate when it differs from the last recorded pointer position. Pointer-move and item-entry behavior continue using the existing recorded direction, preserving the current grace-area behavior.A Playwright regression test uses the existing narrow-viewport nested submenu, verifies that it collision-flipped to the left, and clicks its item with a single pointer move.
Testing
pnpm format:checkpnpm lintpnpm test --run(37 files, 464 passed, 2 skipped)pnpm types:checkpnpm build(62 packages)pnpm exec playwright test e2e/dropdown-menu.spec.ts --project=chromium(17 passed)