Format files with multiple threads#1041
Open
jvierling wants to merge 4 commits into
Open
Conversation
This is a preparatory step for the implementation of concurrent formatting to rule out mutation of the options.
* Adds mojo parameter `threads` to control the number of threads used for formatting. * Java and Javascript formatters use thread locals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements multi-threaded formatting using a fixed-size thread pool (resolves #537). The number of threads can be configured by a Mojo parameter and defaults to 1. The formatters that may not be thread-safe are instantiated as ThreadLocals. As preparatory step the type of the formatter options are narrowed to ImmutableMap to rule out any mutation.