Skip to content

docs(deploy): add container runner page#5392

Open
abcxff wants to merge 1 commit into
stack/ci-publish-build-and-publish-container-runner-release-artifacts-lysuzrozfrom
stack/docs-deploy-add-container-runner-page-mqospzuu
Open

docs(deploy): add container runner page#5392
abcxff wants to merge 1 commit into
stack/ci-publish-build-and-publish-container-runner-release-artifacts-lysuzrozfrom
stack/docs-deploy-add-container-runner-page-mqospzuu

Conversation

@abcxff

@abcxff abcxff commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@abcxff

abcxff commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

@claude

claude Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review

Docs-only change (new deploy/container-runner.mdx page + sitemap entry). I cross-checked the page's technical claims against the actual container-runner/ implementation and CI config, and everything lines up:

  • CLI flags/env vars/defaults table matches container-runner/src/main.rs exactly (--port resolution order, CHILD_PORT/7770, RIVET_ACTOR_NAME/game, RIVET_RUNNER_VERSION/1, RIVET_SERVERLESS_BASE_PATH//api/rivet, RIVET_STOP_GRACE_SECS/25, RIVET_READINESS_TIMEOUT_SECS/30).
  • Per-actor input JSON schema (command/args/env/port) matches container-runner/src/input.rs::ActorInput.
  • Release artifact URL pattern (releases.rivet.dev/rivet/{version}/container-runner/rivet-container-runner-<target>) matches the upload_prefix: container-runner artifacts in .github/workflows/publish.yaml.
  • --instance-request-concurrency 1 deploy flag exists in engine/packages/cli/src/commands/deploy.rs and its semantics ("concurrent requests per instance") correctly support the "one actor per container" recommendation.
  • rivet WebSocket subprotocol claim matches WS_PROTOCOL_STANDARD = "rivet" in rivetkit-typescript.
  • Frontmatter (title/description/skill) matches the required docs schema, the /docs/deploy/rivet-compute link target exists, and the dockerfile @nocheck annotation follows the same convention used elsewhere for non-typecheckable snippets.
  • Sitemap addition is correctly nested under Deploy alongside the existing Reference section.

No bugs, security concerns, or test-coverage gaps to flag. Nothing here is executable, so there's nothing to unit test, and the content is accurate as written. Nice, tight page.

Nitpick (non-blocking): the new "Advanced" sidebar section under Deploy has a single entry. Fine as-is, but worth folding into "Reference" if it doesn't grow.

@abcxff abcxff force-pushed the stack/docs-deploy-add-container-runner-page-mqospzuu branch from 58139d1 to cc74539 Compare July 9, 2026 22:00
@abcxff abcxff force-pushed the stack/ci-publish-build-and-publish-container-runner-release-artifacts-lysuzroz branch from d123997 to 1a80bdd Compare July 9, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant