ci(publish): build and publish container runner release artifacts#5393
Conversation
|
Stack for rivet-dev/rivet
Get stack: change lysuzroz |
ReviewThis PR adds the Overview
Overall this is a well-documented, carefully-reasoned crate. The module doc comments explain several non-obvious races/ordering constraints (reaper-task ownership of Code quality / convention notes
Potential issues
Test coverage
CI / Docker
Nice addition overall. The invariants around single-actor-per-container are enforced defensively in multiple places (port-reuse guard, duplicate-start guard, cross-actor guard) rather than just assumed, which is exactly the kind of defensive design this component needs given it's the untrusted-boundary-facing piece. |
d123997 to
1a80bdd
Compare
a8b9943 to
081809c
Compare
1a80bdd to
f1606eb
Compare
081809c to
be744d4
Compare
No description provided.