Replay mutation DOMException refactor - #1907
Open
eoghanmurray wants to merge 8 commits into
Open
Conversation
…nded to warn against was when parent incorrectly resolved to a #text node (a logical error in the fullsnapshot + mutation stream). The explicit instanceof DOMException did not work with rrdom. Replace with an explicit nodeType check
…Id is not the parent; both are caused by the same scenario - applying mutations to the 'wrong' replay state (against a different fullsnapshot or a prior mutation is missing)
🦋 Changeset detectedLatest commit: 2b5bd50 The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size ChangesSize change: +5.73 kB (+0.06%) | Total size: 10431.54 kB
|
| File | Base | PR | Diff |
|---|---|---|---|
all.cjs |
567.78 kB | 568.17 kB | +399 B (+0.07%) |
all.js |
567.45 kB | 567.84 kB | +399 B (+0.07%) |
all.umd.cjs |
570.99 kB | 571.38 kB | +399 B (+0.07%) |
all.umd.min.cjs |
269.09 kB | 269.39 kB | +315 B (+0.11%) |
replay - 1407.10 kB -> 1408.50 kB (+1.39 kB (+0.10%))
| File | Base | PR | Diff |
|---|---|---|---|
replay.cjs |
403.84 kB | 404.21 kB | +377 B (+0.09%) |
replay.js |
403.75 kB | 404.11 kB | +377 B (+0.09%) |
replay.umd.cjs |
406.82 kB | 407.19 kB | +377 B (+0.09%) |
replay.umd.min.cjs |
192.70 kB | 192.99 kB | +293 B (+0.15%) |
rrweb - 1913.48 kB -> 1914.96 kB (+1.48 kB (+0.08%))
| File | Base | PR | Diff |
|---|---|---|---|
rrweb.cjs |
550.94 kB | 551.33 kB | +399 B (+0.07%) |
rrweb.js |
550.64 kB | 551.03 kB | +399 B (+0.07%) |
rrweb.umd.cjs |
552.16 kB | 552.55 kB | +399 B (+0.07%) |
rrweb.umd.min.cjs |
259.74 kB | 260.05 kB | +315 B (+0.12%) |
rrweb-player - 1643.88 kB -> 1645.27 kB (+1.39 kB (+0.08%))
| File | Base | PR | Diff |
|---|---|---|---|
rrweb-player.cjs |
473.37 kB | 473.73 kB | +377 B (+0.08%) |
rrweb-player.js |
473.24 kB | 473.61 kB | +377 B (+0.08%) |
rrweb-player.umd.cjs |
476.16 kB | 476.53 kB | +377 B (+0.08%) |
rrweb-player.umd.min.cjs |
221.11 kB | 221.39 kB | +293 B (+0.13%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous DOMException try/catch added by me in #620 was added to ensure that an entire mutation didn't cause an exception when a particular removes mutation was not found. This PR:
The scenario is 'degenerate' replay state, e.g. applying mutations against a different fullsnapshot or when a prior mutation is missing, so I haven't added testing as it's not something that we need to care about if other mechanisms are in place to ensure replay integrity.