Develop#94
Merged
Merged
Conversation
…ete surfaces Builds on @fengjikui's PR #93. Anchors containment at the project root — a `.agentsmesh` boundary canonicalizes through a symlinked `.agentsmesh` and cancels, so a symlinked parent still escaped — and extends the guard to every remaining MCP filesystem surface: - settings config reads AND writes (get/update config, permissions, hooks, ignore, mcp servers) via the readYaml/atomicWrite/safeConfigWrite choke points - canonical list(); create() and delete() on canonical + skills - read-before-write pre-reads (updatePermissions/updateIgnore append) Hardening: fail-closed canonicalize (only ENOENT reconstructs), assert-before existence probe (removes an out-of-project filename oracle), dangling-symlink doc note, and it.skipIf(win) on all symlink tests (unprivileged Windows symlink() throws EPERM on the windows-latest CI matrix). Also drops the unrelated lessons.json trigger churn that rode in the original PR. Co-authored-by: sampleXbro <55853222+sampleXbro@users.noreply.github.com>
…nment fix(mcp): reject symlink path escapes
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change
Checklist
pnpm test,pnpm lint,pnpm typecheck)pnpm changeset) for user-visible changes