Add CTST coverage for Days=0 lifecycle expiration#2461
Draft
delthas wants to merge 2 commits into
Draft
Conversation
…ration backbeat 9.5.0-preview.1 -> 9.5.0-preview.3 (BB-791) cloudserver 9.4.0-preview.2 -> 9.4.0-preview.4 (CLDSRV-928, arsenal 8.5.6) pensieve-api 1.10.1 -> 1.11.0-preview.1 (PSVAPI-128) Issue: ZENKO-5314
Contributor
Hello delthas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
Add an end-to-end test using the S3 PutBucketLifecycleConfiguration API with two scenarios: a non-versioned bucket where Expiration Days=0 deletes all objects, and a versioned bucket where Expiration Days=0 combined with NoncurrentVersionExpiration NoncurrentDays=0 removes all versions and delete markers. Factor the lifecycle-config PUT-with-retry logic shared with the transition workflow helper into putBucketLifecycleConfigurationWithRetry, and add an addExpirationWorkflow helper. Days=0 makes objects immediately eligible, so the test needs no time-progression or one-day-earlier tricks. Issue: ZENKO-5314
edabef9 to
9061fa1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why do we need it?
Adds end-to-end (CTST) coverage for S3 lifecycle Expiration rules with
Days=0("delete all matching objects as soon as backbeat runs"), and bumps the component images that ship the feature.solution/deps.yaml: backbeat9.5.0-preview.1→9.5.0-preview.3(BB-791), cloudserver9.4.0-preview.2→9.4.0-preview.4(CLDSRV-928, arsenal 8.5.6), pensieve-api1.10.1→1.11.0-preview.1(PSVAPI-128).features/lifecycleExpiration.featurewith two@PreMergescenarios using the direct S3PutBucketLifecycleConfigurationAPI:Expiration Days=0→ all objects deleted;Expiration Days=0+NoncurrentVersionExpiration NoncurrentDays=0→ all versions and delete markers removed.putBucketLifecycleConfigurationWithRetry, and adds anaddExpirationWorkflowhelper.Days=0makes objects immediately eligible (backbeat lists with noBeforeDate), so the test needs no time-progression or one-day-earlier tricks and is not tagged@Flaky.The backbeat index-skip heuristic (BB-779) is intentionally out of scope — it is not yet merged and is covered by backbeat unit tests, not e2e.
Which issue does this PR fix?
ZENKO-5314
Special notes for your reviewers:
The new scenarios follow
tests/functional/ctst/HOW_TO_WRITE_TESTS.md: unique per-scenario buckets, external-state-only assertions (viaListObjectVersions), poll-based assertions (idempotent after waits), automatic teardown via the globalAfterhook, and no@Flaky.Issue: ZENKO-5314