[UIK-5351][theme] Add more variables to theme#3039
Open
j-mnizhek wants to merge 6 commits into
Open
Conversation
github-actions
Bot
added
badge
feature-highlight
base-components
base-trigger
select
time-picker
add-filter
date-picker
button
wizard
side-panel
pagination
notice-bubble
feedback-form
modal
fullscreen-modal
carousel
notice
inline-input
feature-popover
errors
dropdown-menu
data-table
color-picker
card
drag-and-drop
bulk-textarea
labels
j-mnizhek
requested review from
Valeria-Zimnitskaya,
ilyabrower and
slizhevskyv-semrush
ilyabrower
reviewed
Jul 3, 2026
| cursor: pointer; | ||
|
|
||
| background: var(--intergalactic-bg-primary-neutral, oklch(1 0 0)); | ||
| background: var(--intergalactic-bg-primary-neutral, oklch(1 0 0)); /* TODO: --intergalactic-control-select-trigger-normal */ |
Contributor
There was a problem hiding this comment.
why control-select instead of select ?
why select instead of trigger?
| box-sizing: border-box; | ||
| background-size: 12px; | ||
| background-color: var(--intergalactic-control-primary-info, oklch(0.23 0.01 140)); | ||
| background-color: var(--intergalactic-control-primary-info, oklch(0.23 0.01 140)); /* TODO: --intergalactic-control-slider-bar-value */ |
| box-sizing: border-box; | ||
| background-color: var(--intergalactic-bg-primary-neutral, oklch(1 0 0)); | ||
| border: 5px solid var(--intergalactic-control-primary-info, oklch(0.23 0.01 140)); | ||
| background-color: var(--intergalactic-bg-primary-neutral, oklch(1 0 0)); /* TODO: --intergalactic-control-slider-knob */ |
| STag[theme="additional-invert"], | ||
| STagContainerClose[theme="additional-invert"] { | ||
| color: var(--intergalactic-text-primary-invert, oklch(0.999 0.001 180 / 0.949)); | ||
| color: var(--intergalactic-text-primary-invert, oklch(0.999 0.001 180 / 0.949)); /* TODO:--intergalactic-tag-secondary-white-text */ |
Member
Author
There was a problem hiding this comment.
Because we have variable for white text in Tags already. It's not semantical initially, because we cannot connect Tag colors to the specific semantic: different products can use, for example, green tag for different purposes. That's why Tag's variables are tied to colors initially. Not sure about invert here (didn't want to rename too many variables), but if it's okay to rename a bit more vars then I'll think about the invert in the name
ilyabrower
reviewed
Jul 3, 2026
| value: neutral.at(L_BG_PRIMARY), | ||
| description: 'Primary background of the interface which contains the main data and information.', | ||
| badge_bg_admin: { | ||
| value: '{baseTokens.colors.blue.400}', |
Contributor
There was a problem hiding this comment.
let's use colors.blue['400'].value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
@semcore/theme
Added
Motivation and Context
How has this been tested?
Manually.
Types of changes
Checklist: